From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javierm@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH 09/14] drm/panel-samsung-s6e88a0-ams452ef01: Drop custom DSI write macro
Date: Wed, 28 Dec 2022 02:47:52 +0100 [thread overview]
Message-ID: <20221228014757.3170486-10-javierm@redhat.com> (raw)
In-Reply-To: <20221228014757.3170486-1-javierm@redhat.com>
There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
.../panel/panel-samsung-s6e88a0-ams452ef01.c | 24 +++++++------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c
index 97ff7a18545c..e94d88fed4f3 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c
@@ -28,14 +28,6 @@ s6e88a0_ams452ef01 *to_s6e88a0_ams452ef01(struct drm_panel *panel)
return container_of(panel, struct s6e88a0_ams452ef01, panel);
}
-#define dsi_dcs_write_seq(dsi, seq...) do { \
- static const u8 d[] = { seq }; \
- int ret; \
- ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d)); \
- if (ret < 0) \
- return ret; \
- } while (0)
-
static void s6e88a0_ams452ef01_reset(struct s6e88a0_ams452ef01 *ctx)
{
gpiod_set_value_cansleep(ctx->reset_gpio, 1);
@@ -54,8 +46,8 @@ static int s6e88a0_ams452ef01_on(struct s6e88a0_ams452ef01 *ctx)
dsi->mode_flags |= MIPI_DSI_MODE_LPM;
- dsi_dcs_write_seq(dsi, 0xf0, 0x5a, 0x5a); // enable LEVEL2 commands
- dsi_dcs_write_seq(dsi, 0xcc, 0x4c); // set Pixel Clock Divider polarity
+ mipi_dsi_dcs_write_seq(dsi, 0xf0, 0x5a, 0x5a); // enable LEVEL2 commands
+ mipi_dsi_dcs_write_seq(dsi, 0xcc, 0x4c); // set Pixel Clock Divider polarity
ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
if (ret < 0) {
@@ -65,7 +57,7 @@ static int s6e88a0_ams452ef01_on(struct s6e88a0_ams452ef01 *ctx)
msleep(120);
// set default brightness/gama
- dsi_dcs_write_seq(dsi, 0xca,
+ mipi_dsi_dcs_write_seq(dsi, 0xca,
0x01, 0x00, 0x01, 0x00, 0x01, 0x00, // V255 RR,GG,BB
0x80, 0x80, 0x80, // V203 R,G,B
0x80, 0x80, 0x80, // V151 R,G,B
@@ -77,11 +69,11 @@ static int s6e88a0_ams452ef01_on(struct s6e88a0_ams452ef01 *ctx)
0x6b, 0x68, 0x71, // V3 R,G,B
0x00, 0x00, 0x00); // V1 R,G,B
// set default Amoled Off Ratio
- dsi_dcs_write_seq(dsi, 0xb2, 0x40, 0x0a, 0x17, 0x00, 0x0a);
- dsi_dcs_write_seq(dsi, 0xb6, 0x2c, 0x0b); // set default elvss voltage
- dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00);
- dsi_dcs_write_seq(dsi, 0xf7, 0x03); // gamma/aor update
- dsi_dcs_write_seq(dsi, 0xf0, 0xa5, 0xa5); // disable LEVEL2 commands
+ mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x40, 0x0a, 0x17, 0x00, 0x0a);
+ mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x2c, 0x0b); // set default elvss voltage
+ mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00);
+ mipi_dsi_dcs_write_seq(dsi, 0xf7, 0x03); // gamma/aor update
+ mipi_dsi_dcs_write_seq(dsi, 0xf0, 0xa5, 0xa5); // disable LEVEL2 commands
ret = mipi_dsi_dcs_set_display_on(dsi);
if (ret < 0) {
--
2.38.1
next prev parent reply other threads:[~2022-12-28 1:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 1:47 [PATCH 00/14] drm/panel: Make panel drivers use existing DSI write macros Javier Martinez Canillas
2022-12-28 1:47 ` [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro Javier Martinez Canillas
2022-12-29 15:36 ` kernel test robot
2023-01-02 18:39 ` Sam Ravnborg
2023-01-02 18:59 ` Javier Martinez Canillas
2023-01-02 19:02 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 02/14] drm/panel-asus-z00t-tm5p5-n35596: Drop custom DSI write macros Javier Martinez Canillas
2022-12-28 1:47 ` [PATCH 03/14] drm/panel-sitronix-st7703: " Javier Martinez Canillas
2022-12-28 12:01 ` Guido Günther
2022-12-29 14:30 ` Javier Martinez Canillas
2023-01-02 18:42 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 04/14] drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro Javier Martinez Canillas
2023-01-02 18:43 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 05/14] drm/panel-elida-kd35t133: " Javier Martinez Canillas
2023-01-02 18:44 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 06/14] drm/panel-boe-bf060y8m-aj0: " Javier Martinez Canillas
2023-01-02 18:45 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 07/14] drm/panel-novatek-nt35950: " Javier Martinez Canillas
2023-01-02 18:55 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 08/14] drm/panel-jdi-fhd-r63452: Drop custom DSI write macros Javier Martinez Canillas
2023-01-02 18:46 ` Sam Ravnborg
2022-12-28 1:47 ` Javier Martinez Canillas [this message]
2023-01-02 18:48 ` [PATCH 09/14] drm/panel-samsung-s6e88a0-ams452ef01: Drop custom DSI write macro Sam Ravnborg
2022-12-28 1:47 ` [PATCH 10/14] drm/panel-samsung-sofef00: " Javier Martinez Canillas
2023-01-02 18:56 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 11/14] drm/panel-sharp-ls060t1sx01: " Javier Martinez Canillas
2023-01-02 18:50 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 12/14] drm/panel-mantix-mlaf057we51: " Javier Martinez Canillas
2023-01-02 18:56 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 13/14] drm/panel-sony-tulip-truly-nt35521: " Javier Martinez Canillas
2023-01-02 18:51 ` Sam Ravnborg
2022-12-28 1:47 ` [PATCH 14/14] drm/panel-xinpeng-xpp055c272: " Javier Martinez Canillas
2023-01-02 18:53 ` Sam Ravnborg
2023-01-02 19:08 ` Javier Martinez Canillas
2023-01-02 19:00 ` [PATCH 00/14] drm/panel: Make panel drivers use existing DSI write macros Sam Ravnborg
2023-01-02 19:13 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228014757.3170486-10-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).