* [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource()
@ 2022-11-22 1:40 ye.xingchen
2022-11-22 9:08 ` Marco Felsch
2022-12-31 7:21 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2022-11-22 1:40 UTC (permalink / raw)
To: shawnguo; +Cc: s.hauer, kernel, linux-arm-kernel, linux-kernel, chi.minghao
From: Minghao Chi <chi.minghao@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/bus/imx-weim.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..2a6b4f676458 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
static int weim_probe(struct platform_device *pdev)
{
struct weim_priv *priv;
- struct resource *res;
struct clk *clk;
void __iomem *base;
int ret;
@@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
return -ENOMEM;
/* get the resource */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource()
2022-11-22 1:40 [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2022-11-22 9:08 ` Marco Felsch
2022-12-31 7:21 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Marco Felsch @ 2022-11-22 9:08 UTC (permalink / raw)
To: ye.xingchen
Cc: shawnguo, chi.minghao, s.hauer, linux-arm-kernel, kernel, linux-kernel
Hi Chi,
thanks for your patch.
On 22-11-22, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
LGTM, feel free to add my
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> drivers/bus/imx-weim.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..2a6b4f676458 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
> static int weim_probe(struct platform_device *pdev)
> {
> struct weim_priv *priv;
> - struct resource *res;
> struct clk *clk;
> void __iomem *base;
> int ret;
> @@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* get the resource */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource()
2022-11-22 1:40 [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-22 9:08 ` Marco Felsch
@ 2022-12-31 7:21 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-12-31 7:21 UTC (permalink / raw)
To: ye.xingchen; +Cc: s.hauer, kernel, linux-arm-kernel, linux-kernel, chi.minghao
On Tue, Nov 22, 2022 at 09:40:52AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-31 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 1:40 [PATCH] bus: imx-weim: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-22 9:08 ` Marco Felsch
2022-12-31 7:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).