* [PATCH v1] arm64: dts: imx8mq-librem5: use multicolor leds description for RGB led
@ 2022-11-30 11:31 Martin Kepplinger
2022-12-31 12:01 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2022-11-30 11:31 UTC (permalink / raw)
To: robh, krzysztof.kozlowski, shawnguo, s.hauer, kernel, festevam
Cc: linux-imx, kernel, devicetree, linux-arm-kernel, phone-devel,
linux-kernel, Martin Kepplinger
As Documentation/leds/well-known-leds.txt says, "Phones usually have
multi-color status LED." Fix that for the Librem 5 mobile phone board.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
.../boot/dts/freescale/imx8mq-librem5.dtsi | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index ddf0e330dc7c..6895bcc12165 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -56,27 +56,27 @@ key-vol-up {
};
led-controller {
- compatible = "pwm-leds";
+ compatible = "pwm-leds-multicolor";
- led-0 {
+ multi-led {
+ color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STATUS;
- color = <LED_COLOR_ID_BLUE>;
max-brightness = <248>;
- pwms = <&pwm2 0 50000 0>;
- };
- led-1 {
- function = LED_FUNCTION_STATUS;
- color = <LED_COLOR_ID_GREEN>;
- max-brightness = <248>;
- pwms = <&pwm4 0 50000 0>;
- };
+ led-0 {
+ color = <LED_COLOR_ID_BLUE>;
+ pwms = <&pwm2 0 50000 0>;
+ };
- led-2 {
- function = LED_FUNCTION_STATUS;
- color = <LED_COLOR_ID_RED>;
- max-brightness = <248>;
- pwms = <&pwm3 0 50000 0>;
+ led-1 {
+ color = <LED_COLOR_ID_GREEN>;
+ pwms = <&pwm4 0 50000 0>;
+ };
+
+ led-2 {
+ color = <LED_COLOR_ID_RED>;
+ pwms = <&pwm3 0 50000 0>;
+ };
};
};
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] arm64: dts: imx8mq-librem5: use multicolor leds description for RGB led
2022-11-30 11:31 [PATCH v1] arm64: dts: imx8mq-librem5: use multicolor leds description for RGB led Martin Kepplinger
@ 2022-12-31 12:01 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2022-12-31 12:01 UTC (permalink / raw)
To: Martin Kepplinger
Cc: robh, krzysztof.kozlowski, s.hauer, kernel, festevam, linux-imx,
kernel, devicetree, linux-arm-kernel, phone-devel, linux-kernel
On Wed, Nov 30, 2022 at 12:31:24PM +0100, Martin Kepplinger wrote:
> As Documentation/leds/well-known-leds.txt says, "Phones usually have
> multi-color status LED." Fix that for the Librem 5 mobile phone board.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-31 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-30 11:31 [PATCH v1] arm64: dts: imx8mq-librem5: use multicolor leds description for RGB led Martin Kepplinger
2022-12-31 12:01 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).