From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <mirsad.todorovac@alu.unizg.hr>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <fw@strlen.de>,
<kuba@kernel.org>, <kuniyu@amazon.co.jp>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>, <shuah@kernel.org>,
<kuniyu@amazon.com>
Subject: [PATCH selftest/net/af_unix 1/1] Fix size of parameter to connect()
Date: Sat, 7 Jan 2023 02:58:28 +0900 [thread overview]
Message-ID: <20230106175828.13333-1-kuniyu@amazon.com> (raw)
In-Reply-To: <bd7ff00a-6892-fd56-b3ca-4b3feb6121d8@alu.unizg.hr>
Hi,
Thanks for the patch.
From: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Date: Fri, 6 Jan 2023 18:18:58 +0100
> From: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
>
> Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory"
> error in selftests/net/af_unix/test_oob_unix.c:127.
Could you wrap the changelog to 75 chars except for log (strace below) ?
checkpatch.pl will help.
$ git show HEAD --format=email | ./scripts/checkpatch.pl
>
> The existing code happens to work provided that the autogenerated pathname is shorter than
> sizeof (struct sockaddr), which is why it hasn't been noticed earlier.
>
> Visible from the trace excerpt:
>
> bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0
> clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060
> [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
>
> BUG: The filename is trimmed to sizeof (struct sockaddr).
>
> The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2.
Every patch that fixes networking code has to be applied cleanly on net.git.
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
But the patch can not be applied to net.git.
Could you check this ?
https://patchwork.kernel.org/project/netdevbpf/patch/bd7ff00a-6892-fd56-b3ca-4b3feb6121d8@alu.unizg.hr/
Also, the mail title should be
[PATCH Tree Version Nth/Total] subsystem: Description.
Next time, Tree is net and Version is v2, and we need not write 1/1, so the
subject should be
[PATCH net v2] af_unix: selftest: Fix size of parameter to connect()
Please see here for details.
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/process/maintainer-netdev.rst
>
> Thanks and regards,
> Mirsad Todorovac
You can remove these lines.
>
> Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
In this case, you are the reporter and the author of the patch, so the
Reported-by tag is not needed. Instead, you have to add your SOB tag.
Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> Cc: Florian Westphal <fw@strlen.de>
> Reviewed-by: Florian Westphal <fw@strlen.de>
Please add Fixes tag as I said here.
https://lore.kernel.org/netdev/20230103111335.81600-1-kuniyu@amazon.com/#r
Thank you,
Kuniyuki
>
> ---
> tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c
> index b57e91e1c3f2..532459a15067 100644
> --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c
> +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c
> @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
>
> wait_for_signal(pipefd[0]);
> if (connect(cfd, (struct sockaddr *)consumer_addr,
> - sizeof(struct sockaddr)) != 0) {
> + sizeof(*consumer_addr)) != 0) {
> perror("Connect failed");
> kill(0, SIGTERM);
> exit(1);
>
> --
> Mirsad Goran Todorovac
> Sistem inženjer
> Grafički fakultet | Akademija likovnih umjetnosti
> Sveučilište u Zagrebu
> --
> System engineer
> Faculty of Graphic Arts | Academy of Fine Arts
> University of Zagreb, Republic of Croatia
> The European Union
next prev parent reply other threads:[~2023-01-06 17:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 17:18 [PATCH selftest/net/af_unix 1/1] Fix size of parameter to connect() Mirsad Goran Todorovac
2023-01-06 17:58 ` Kuniyuki Iwashima [this message]
2023-01-06 19:19 ` Mirsad Goran Todorovac
2023-01-06 19:28 ` [PATCH net v2] af_unix: selftest: Fix the size of the " Mirsad Goran Todorovac
2023-01-07 0:14 ` Jakub Kicinski
2023-01-07 1:37 ` [PATCH net v3] " Mirsad Goran Todorovac
2023-01-07 1:42 ` [PATCH net v2] " Mirsad Goran Todorovac
2023-01-07 2:08 ` Jakub Kicinski
2023-01-07 3:36 ` Mirsad Goran Todorovac
2023-01-07 3:40 ` [PATCH net v4] " Mirsad Goran Todorovac
2023-01-09 1:15 ` Kuniyuki Iwashima
2023-01-09 8:53 ` Mirsad Goran Todorovac
2023-01-09 8:20 ` patchwork-bot+netdevbpf
2023-01-08 21:30 ` [PATCH net v2] " Mirsad Goran Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106175828.13333-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).