From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E6EC46467 for ; Wed, 11 Jan 2023 22:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236305AbjAKWbK (ORCPT ); Wed, 11 Jan 2023 17:31:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236111AbjAKWa7 (ORCPT ); Wed, 11 Jan 2023 17:30:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A08F35F48; Wed, 11 Jan 2023 14:30:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A94461EE7; Wed, 11 Jan 2023 22:30:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6359AC433EF; Wed, 11 Jan 2023 22:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673476257; bh=KUi1HGeABxjWRsu8PJIH+JwPcZ8NI+ELZCnpYlQMHT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Kf0tL8z6062nMukSXj1bvr1p2+gTipJIIAonn6AF+NvYFqLCjffe3AnTHerJKON4X 4XlVyqh7SbpnYnHGKCJbqki8pLXtRRlMGXCjRA2bX1+cAM/MWZh6Y2PqP5kOi4P8aA TAU6ux9d7GP3M2hHkNjcAdghPQeR+OEVwmJoRHDZOUGGdb0Wsf01iMHwJfU8Zms/5z E4yextY1IkFAA1H7ZGLXLOvrYvuC6m2qjKYBlQwvzX8m3JRi3zg/98ASwD1hvhjIEP 7EzqVSMkcUU0QWS7IPBmijS7p9sO2De9edsnyvU/9V/1m7ZblnP86jQCSVw1BazflW zALJ7OVhpjOEw== Date: Wed, 11 Jan 2023 16:30:55 -0600 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Dan J Williams , Kan Liang , Tony Luck , David E Box , Yunying Sun , Dave Jiang , Mika Westerberg , Giovanni Cabiddu , Herbert Xu , Hans de Goede , Florent DELAHAYE , Konrad J Hambrick , Matt Hansen <2lprbe78@duck.com>, Nicholas Johnson , Benoit =?iso-8859-1?Q?Gr=E9goire?= , Werner Sembach , mumblingdrunkard@protonmail.com, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 0/2] PCI: Fix extended config space regression Message-ID: <20230111223055.GA1712775@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230110180243.1590045-1-helgaas@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2023 at 12:02:41PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map") appeared > in v6.2-rc1 and broke extended config space on several machines. > > This broke drivers that use things in extended config space, e.g., perf, > VSEC telemetry, EDAC, QAT, etc. > > This happened because mmconfig-shared.c checks to see that ECAM space is > reserved in E820 or ACPI motherboard resources. If it's not, it assumes > ECAM doesn't work. 07eab0901ede removed some E820 entries, so it looked > like ECAM was no longer reserved, so we stopped using it. > > The machines where this broke don't reserve the ECAM in ACPI PNP0C02 > devices (which seems to be what the PCI Firmware spec requires), but they > do mention it in the EFI memory map as EfiMemoryMappedIO. > > Bjorn Helgaas (2): > x86/pci: Simplify is_mmconf_reserved() messages > x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space > > arch/x86/pci/mmconfig-shared.c | 44 +++++++++++++++++++++++++++++----- > 1 file changed, 38 insertions(+), 6 deletions(-) Applied to for-linus for v6.2. Sorry for the breakage and thank you very much for the debugging and testing help!