From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DA1C3DA78 for ; Fri, 13 Jan 2023 19:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbjAMTnc (ORCPT ); Fri, 13 Jan 2023 14:43:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbjAMTmt (ORCPT ); Fri, 13 Jan 2023 14:42:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F3D68A21C; Fri, 13 Jan 2023 11:42:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DB1E7B821AC; Fri, 13 Jan 2023 19:42:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 726D1C433EF; Fri, 13 Jan 2023 19:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673638928; bh=i5SPJ9ruDKdO5PXYBwEMgHw4eQ3C0NHYLRm6fxx4hbc=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=tOe7T6zrHqmhtikKHhD2/Tk53HWJzJD7S0mB40dvvplRG5gksdW+mnEbAb2mnFXZm Wq/mf81WAoR8E9v1vMJimY26ahEjgol080MbIKUHpixETGL30GlunSvKNNU/K/i2XQ 9SM2szylTpDzRVMivfEbstB0teX/eH9uYiyFNGvA/RUEVAFAF+/RtGlRqA1f6dTqF6 pfNyzkvB3lHG4te1oxeujIrClz45lM9ksLKR2qBO6OLPtBpR+EU6uvumTA2M/cbsh+ MguU4c5N2++dYSgbzcoIno3sxLWAaQi1pqQ2421OhNLu367Uk5qLGR/oiymoEXSuOZ 59TpV2nl7P9cA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 155B55C06D0; Fri, 13 Jan 2023 11:42:08 -0800 (PST) Date: Fri, 13 Jan 2023 11:42:08 -0800 From: "Paul E. McKenney" To: "Wysocki, Rafael J" Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Borislav Petkov , Alan Stern , John Ogness Subject: Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU Message-ID: <20230113194208.GE4028633@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20230113001103.GA3374173@paulmck-ThinkPad-P17-Gen-1> <20230113001132.3375334-15-paulmck@kernel.org> <608756bb-3012-e02c-5b16-04314cdc9889@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <608756bb-3012-e02c-5b16-04314cdc9889@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2023 at 12:25:48PM +0100, Wysocki, Rafael J wrote: > > On 1/13/2023 1:11 AM, Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in conditional compilation based on CONFIG_SRCU. > > Therefore, remove the #ifdef. > > > > Signed-off-by: Paul E. McKenney > > Cc: "Rafael J. Wysocki" > > Cc: "Michał Mirosław" > > Cc: Borislav Petkov > > Cc: Alan Stern > > Reviewed-by: John Ogness > > Acked-by: Rafael J. Wysocki Thank you! I will apply both of your acks on my next rebase. Thanx, Paul > > --- > > kernel/notifier.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/kernel/notifier.c b/kernel/notifier.c > > index ab75637fd904f..d353e4b5402d7 100644 > > --- a/kernel/notifier.c > > +++ b/kernel/notifier.c > > @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh, > > } > > EXPORT_SYMBOL_GPL(raw_notifier_call_chain); > > -#ifdef CONFIG_SRCU > > /* > > * SRCU notifier chain routines. Registration and unregistration > > * use a mutex, and call_chain is synchronized by SRCU (no locks). > > @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh) > > } > > EXPORT_SYMBOL_GPL(srcu_init_notifier_head); > > -#endif /* CONFIG_SRCU */ > > - > > static ATOMIC_NOTIFIER_HEAD(die_chain); > > int notrace notify_die(enum die_val val, const char *str,