From: Pietro Borrello <borrello@diag.uniroma1.it>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Hanno Zulla <kontakt@hanno.de>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>,
Roderick Colenbrander <roderick.colenbrander@sony.com>,
Sven Eckelmann <sven@narfation.org>
Cc: linux-leds@vger.kernel.org,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>, Jakob Koschel <jkl820.git@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>,
Roderick Colenbrander <roderick@gaikai.com>,
Pietro Borrello <borrello@diag.uniroma1.it>
Subject: [PATCH v2 3/5] HID: dualsense_remove: manually unregister leds
Date: Tue, 31 Jan 2023 13:08:47 +0000 [thread overview]
Message-ID: <20230125-hid-unregister-leds-v2-3-689cc62fc878@diag.uniroma1.it> (raw)
In-Reply-To: <20230125-hid-unregister-leds-v2-0-689cc62fc878@diag.uniroma1.it>
Unregister the LED controllers before device removal, to prevent
unnecessary runs of dualsense_player_led_set_brightness().
Fixes: 8c0ab553b072 ("HID: playstation: expose DualSense player LEDs through LED class.")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
---
Contrary to the other patches in this series, failing to unregister
the led controller does not results into a use-after-free thanks
to the output_worker_initialized variable and the spinlock checks.
Changes in v2:
- Unregister multicolor led controller
- Clarify UAF
- Link to v1: https://lore.kernel.org/all/20230125-hid-unregister-leds-v1-3-9a5192dcef16@diag.uniroma1.it/
---
drivers/hid/hid-playstation.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index 27c40894acab..f23186ca2d76 100644
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -1503,11 +1503,17 @@ static void dualsense_remove(struct ps_device *ps_dev)
{
struct dualsense *ds = container_of(ps_dev, struct dualsense, base);
unsigned long flags;
+ int i;
spin_lock_irqsave(&ds->base.lock, flags);
ds->output_worker_initialized = false;
spin_unlock_irqrestore(&ds->base.lock, flags);
+ for (i = 0; i < ARRAY_SIZE(ds->player_leds); i++)
+ devm_led_classdev_unregister(&ps_dev->hdev->dev, &ds->player_leds[i]);
+
+ devm_led_classdev_multicolor_unregister(&ps_dev->hdev->dev, &ds->lightbar);
+
cancel_work_sync(&ds->output_worker);
}
--
2.25.1
next prev parent reply other threads:[~2023-01-31 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 13:08 [PATCH v2 0/5] HID: manually unregister leds on device removal to prevent UAFs Pietro Borrello
2023-01-31 13:08 ` [PATCH v2 1/5] HID: bigben_remove: manually unregister leds Pietro Borrello
2023-02-09 8:55 ` Benjamin Tissoires
2023-02-09 12:45 ` Pietro Borrello
2023-01-31 13:08 ` [PATCH v2 2/5] HID: asus_remove: manually unregister led Pietro Borrello
2023-01-31 13:08 ` Pietro Borrello [this message]
2023-02-09 8:59 ` [PATCH v2 3/5] HID: dualsense_remove: manually unregister leds Benjamin Tissoires
2023-02-09 12:50 ` Pietro Borrello
2023-01-31 13:08 ` [PATCH v2 4/5] HID: dualshock4_remove: " Pietro Borrello
2023-01-31 13:08 ` [PATCH v2 5/5] HID: sony_remove: " Pietro Borrello
2023-01-31 17:19 ` [PATCH v2 0/5] HID: manually unregister leds on device removal to prevent UAFs Lee Jones
[not found] <20230125-hid-unregister-leds-v2-0-514437b19297@diag.uniroma1.it>
2023-01-26 0:47 ` [PATCH 3/5] HID: dualsense_remove: manually unregister leds Roderick Colenbrander
2023-01-26 12:09 ` [PATCH v2 " Pietro Borrello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125-hid-unregister-leds-v2-3-689cc62fc878@diag.uniroma1.it \
--to=borrello@diag.uniroma1.it \
--cc=benjamin.tissoires@redhat.com \
--cc=c.giuffrida@vu.nl \
--cc=h.j.bos@vu.nl \
--cc=jikos@kernel.org \
--cc=jkl820.git@gmail.com \
--cc=jkosina@suse.cz \
--cc=kontakt@hanno.de \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).