From: Song Liu <song@kernel.org>
To: <linux-kernel@vger.kernel.org>, <linux-modules@vger.kernel.org>,
<live-patching@vger.kernel.org>
Cc: <x86@kernel.org>, Song Liu <song@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Petr Mladek <pmladek@suse.com>
Subject: [PATCH v11 1/2] x86/module: remove unused code in __apply_relocate_add
Date: Wed, 25 Jan 2023 10:54:00 -0800 [thread overview]
Message-ID: <20230125185401.279042-1-song@kernel.org> (raw)
This "#if 0" block has been untouched for many years. Remove it to clean
up the code.
Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Song Liu <song@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
---
arch/x86/kernel/module.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c
index 705fb2a41d7d..1dee3ad82da2 100644
--- a/arch/x86/kernel/module.c
+++ b/arch/x86/kernel/module.c
@@ -188,10 +188,6 @@ static int __apply_relocate_add(Elf64_Shdr *sechdrs,
goto invalid_relocation;
val -= (u64)loc;
write(loc, &val, 4);
-#if 0
- if ((s64)val != *(s32 *)loc)
- goto overflow;
-#endif
break;
case R_X86_64_PC64:
if (*(u64 *)loc != 0)
--
2.30.2
next reply other threads:[~2023-01-25 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 18:54 Song Liu [this message]
2023-01-25 18:54 ` [PATCH v11 2/2] livepatch,x86: Clear relocation targets on a module removal Song Liu
2023-01-25 19:03 ` Josh Poimboeuf
2023-01-27 13:46 ` Joe Lawrence
2023-01-25 19:03 ` [PATCH v11 1/2] x86/module: remove unused code in __apply_relocate_add Josh Poimboeuf
2023-01-27 13:45 ` Joe Lawrence
2023-02-03 13:33 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125185401.279042-1-song@kernel.org \
--to=song@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).