From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS
Date: Wed, 25 Jan 2023 15:13:29 -0600 [thread overview]
Message-ID: <20230125211329.GA2899932-robh@kernel.org> (raw)
In-Reply-To: <20230125175943.675823-1-krzysztof.kozlowski@linaro.org>
On Wed, Jan 25, 2023 at 06:59:43PM +0100, Krzysztof Kozlowski wrote:
> The Samsung Exynos SoC USB 3.0 DWC3 Controller is a simple wrapper of
> actual DWC3 Controller device node. It handles necessary Samsung
> Exynos-specific resources (regulators, clocks), but does not have its
> own MMIO address space.
>
> However neither simple-bus bindings nor dtc W=1 accept device nodes in
> soc@ node which do not have unit address. Therefore allow using
> the address space of child device (actual DWC3 Controller) as the
> wrapper's address.
The correct fix is 'ranges' should have a value. Though the whole
wrapper thing when there are no registers I dislike...
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> DTS fixes are here:
> https://lore.kernel.org/linux-samsung-soc/20230125175751.675090-1-krzysztof.kozlowski@linaro.org/T/#t
> ---
> .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> index 6b9a3bcb3926..a94b1926dda0 100644
> --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> @@ -29,6 +29,9 @@ properties:
>
> ranges: true
>
> + reg:
> + maxItems: 1
> +
> '#size-cells':
> const: 1
>
> @@ -108,8 +111,9 @@ examples:
> #include <dt-bindings/clock/exynos5420.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> - usb {
> + usb-wrapper@12000000 {
> compatible = "samsung,exynos5250-dwusb3";
> + reg = <0x12000000 0x10000>;
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-01-25 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 17:59 [PATCH] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS Krzysztof Kozlowski
2023-01-25 21:13 ` Rob Herring [this message]
2023-01-26 10:48 ` Krzysztof Kozlowski
2023-01-26 13:41 ` Rob Herring
2023-01-26 13:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125211329.GA2899932-robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).