From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AE2C05027 for ; Thu, 26 Jan 2023 09:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235762AbjAZJjE (ORCPT ); Thu, 26 Jan 2023 04:39:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbjAZJjC (ORCPT ); Thu, 26 Jan 2023 04:39:02 -0500 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 077205CFE4 for ; Thu, 26 Jan 2023 01:39:01 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 29D4E3200979; Thu, 26 Jan 2023 04:38:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jan 2023 04:38:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1674725936; x= 1674812336; bh=G2swqMT0vVr/RxeIkV3CkXIFX9WTobaEU+Ba9jbwnhE=; b=a JNRa0FOsNmeLyl/gouQ4G8O9jJSaXs04Lwtv2iQe6HiiMM2Ub1g7xEJls21tZkkv 6gG2QXh/y9cJ/w0SbVC7L3eQnaXv+22AbNEYhYamxsI4POF+DlvPc/imnNsub9zT 3C2/B7xjG+oqinDNyQp0dTEqN/D/TyeX9yLnaRok39Ym8dJTvndY2LYoOJHvUgQ/ TDesSzrTFti6C3V4bL8ko2Xz81GHVCQre75TB5LsKkrGnEZcomrqiPcjY/r76vR+ 9COapY8KE9nj+bzmqC5eVOAqMe07ysEY+nxtcWQaxz0dzKagfqGYWrNwAIkhw6a8 lq0a6ECxUKYgrAcwT1CjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674725936; x= 1674812336; bh=G2swqMT0vVr/RxeIkV3CkXIFX9WTobaEU+Ba9jbwnhE=; b=P +p9ebGXd7z5I+ofKoB31Z1m+lQkW/172RX+4BR1rjKWwErmkyPfFdLscrsNLkB1S 7Jq7NuX5AjemRSTi+S33ro9DENQuK5BaOJ1a+w30DAaTevPdTf4qLoMkuKUlnkHD Zk09Q/4QQynIZGM6+kVD/aF3vPkmE3We2djCK1dNNxLblv5JZ8a4rsCwLrVJfcNq 9B7DCJj7wZ/qckibq62Wn1oIe+8v5l9q73rGj3D/FWPONDduLdY3yz/tWAIGjS16 K+Fhw87nz4AhESHkcAa9ZbjtFtA0KIHc1OSJAQBx5fZzTvakf1B34ke9dLXhYM95 FnQFvc1NiZKO0c/RYZvmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvgedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnheptefgleeggfegkeekgffgleduieduffejffegveevkeejudektdduueet feetfefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Jan 2023 04:38:55 -0500 (EST) Date: Thu, 26 Jan 2023 10:38:53 +0100 From: Maxime Ripard To: Thomas Zimmermann Cc: Emma Anholt , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Stevenson Subject: Re: [PATCH 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range Message-ID: <20230126093853.kqjhswl27kelywov@houat> References: <20221207-rpi-hdmi-improvements-v1-0-6b15f774c13a@cerno.tech> <20221207-rpi-hdmi-improvements-v1-3-6b15f774c13a@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thanks for your review On Wed, Jan 11, 2023 at 03:11:51PM +0100, Thomas Zimmermann wrote: > Am 07.12.22 um 17:07 schrieb Maxime Ripard: > > From: Dave Stevenson > >=20 > > Copy Intel's "Broadcast RGB" property semantics to add manual override > > of the HDMI pixel range for monitors that don't abide by the content > > of the AVI Infoframe. > >=20 > > Signed-off-by: Dave Stevenson > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/vc4/vc4_hdmi.c | 87 +++++++++++++++++++++++++++++++++= +++++++++ > > drivers/gpu/drm/vc4/vc4_hdmi.h | 15 ++++++++ > > 2 files changed, 102 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_h= dmi.c > > index 0eafaf0b76e5..488a4012d422 100644 > > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > > @@ -154,6 +154,11 @@ static bool vc4_hdmi_is_full_range_rgb(struct vc4_= hdmi *vc4_hdmi, > > { > > struct drm_display_info *display =3D &vc4_hdmi->connector.display_in= fo; > > + if (vc4_hdmi->broadcast_rgb =3D=3D VC4_HDMI_BROADCAST_RGB_LIMITED) > > + return false; > > + else if (vc4_hdmi->broadcast_rgb =3D=3D VC4_HDMI_BROADCAST_RGB_FULL) > > + return true; > > + > > return !display->is_hdmi || > > drm_default_rgb_quant_range(mode) =3D=3D HDMI_QUANTIZATION_RANGE_FU= LL; >=20 > The existing code is now the branch for VC4_HDMI_BROADCAST_RGB_AUTO, AFAI= U. I'm not entirely sure what you meant here sorry. The existing code path is indeed the VC4_HDMI_BROADCAST_RGB_AUTO case, which is the property default so the current behaviour should remain by default. Is there anything you want me to clarify? Maxime