From: Oleg Nesterov <oleg@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
"Eric W . Biederman" <ebiederm@xmission.com>,
Frederic Weisbecker <frederic@kernel.org>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH v3] posix-timers: Prefer delivery of signals to the current thread
Date: Thu, 26 Jan 2023 15:46:56 +0100 [thread overview]
Message-ID: <20230126144655.GA4069@redhat.com> (raw)
In-Reply-To: <20230126105128.2249938-1-dvyukov@google.com>
On 01/26, Dmitry Vyukov wrote:
>
> t = pid_task(pid, type);
> + if (t && type != PIDTYPE_PID && same_thread_group(t, current))
> + t = current;
> if (!t || !likely(lock_task_sighand(t, &flags)))
> goto ret;
Feel free to ignore, this is cosmetic/subjective, but
t = pid_task(pid, type);
if (!t)
goto ret;
if (type == PIDTYPE_TGID && same_thread_group(t, current))
t = current;
if (!likely(lock_task_sighand(t, &flags)))
goto ret;
looks a bit more readable/clean to me.
LGTM. Lets wait for Thomas verdict.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2023-01-26 14:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 17:18 [RFC PATCH] posix-timers: Support delivery of signals to the current thread Dmitry Vyukov
2023-01-11 15:49 ` Dmitry Vyukov
2023-01-11 21:28 ` Thomas Gleixner
2023-01-12 11:24 ` [RFC PATCH v2] " Dmitry Vyukov
2023-01-25 12:43 ` Oleg Nesterov
2023-01-25 15:17 ` Oleg Nesterov
2023-01-25 15:34 ` Dmitry Vyukov
2023-01-25 16:31 ` Oleg Nesterov
2023-01-25 16:45 ` Oleg Nesterov
2023-01-25 17:07 ` Oleg Nesterov
2023-01-26 10:58 ` Dmitry Vyukov
2023-01-26 10:56 ` Dmitry Vyukov
2023-01-26 10:51 ` [PATCH v3] posix-timers: Prefer " Dmitry Vyukov
2023-01-26 14:46 ` Oleg Nesterov [this message]
2023-01-26 15:41 ` [PATCH v4] " Dmitry Vyukov
2023-01-26 17:51 ` Marco Elver
2023-01-26 19:57 ` Thomas Gleixner
2023-01-27 6:58 ` Dmitry Vyukov
2023-01-28 19:56 ` Oleg Nesterov
2023-01-28 20:15 ` Oleg Nesterov
2023-01-30 9:00 ` Dmitry Vyukov
2023-01-30 16:49 ` Oleg Nesterov
2023-02-02 7:36 ` Dmitry Vyukov
2023-02-20 14:43 ` [PATCH v5] " Dmitry Vyukov
2023-02-22 15:19 ` Oleg Nesterov
2023-03-14 8:25 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126144655.GA4069@redhat.com \
--to=oleg@redhat.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=elver@google.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).