linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrei Gherzan <andrei.gherzan@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH v2 1/2] selftests: net: Fix missing nat6to4.o when running udpgro_frglist.sh
Date: Thu, 26 Jan 2023 15:36:21 -0800	[thread overview]
Message-ID: <20230126153621.7503a73e@kernel.org> (raw)
In-Reply-To: <Y9JPiA11CHNOMibr@qwirkle>

On Thu, 26 Jan 2023 10:01:44 +0000 Andrei Gherzan wrote:
> On 23/01/25 11:08PM, Jakub Kicinski wrote:
> > On Wed, 25 Jan 2023 21:13:49 +0000 Andrei Gherzan wrote:  
> > > The udpgro_frglist.sh uses nat6to4.o which is tested for existence in
> > > bpf/nat6to4.o (relative to the script). This is where the object is
> > > compiled. Even so, the script attempts to use it as part of tc with a
> > > different path (../bpf/nat6to4.o). As a consequence, this fails the script:  
> > 
> > Is this a recent regression? Can you add a Fixes tag?  
> 
> This issue seems to be included from the beginning (edae34a3ed92). I can't say
> why this was not seen before upstream but on our side, this test was disabled
> internally due to lack of CC support in BPF programs. This was fixed in the
> meanwhile in 837a3d66d698 (selftests: net: Add cross-compilation support for
> BPF programs) and we found this issue while trying to reenable the test.
> 
> So if you think that is reasonable, I could add a Fixes tag for the initial 
> script commit edae34a3ed92 (selftests net: add UDP GRO fraglist + bpf
> self-tests) and push a v3.

We have queued commit 3c107f36db06 ("selftests/net: mv bpf/nat6to4.c 
to net folder") in net-next, I think that should fix it, too?

> > What tree did you base this patch on? Doesn't seem to apply  
> 
> The patches were done on top of
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, the master
> branch - 948ef7bb70c4 (Merge tag 'modules-6.2-rc6' of
> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux). There is another
> merge that happened in the meanwhile but the rebase works without issues. I can
> send a rebased v3 if needed.

Could you try linux-next or net-next ?

  reply	other threads:[~2023-01-26 23:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 21:13 [PATCH v2 1/2] selftests: net: Fix missing nat6to4.o when running udpgro_frglist.sh Andrei Gherzan
2023-01-25 21:13 ` [PATCH v2 2/2] selftests: net: .gitignore the scratch directory of bpf Andrei Gherzan
2023-01-26  7:08 ` [PATCH v2 1/2] selftests: net: Fix missing nat6to4.o when running udpgro_frglist.sh Jakub Kicinski
2023-01-26 10:01   ` Andrei Gherzan
2023-01-26 23:36     ` Jakub Kicinski [this message]
2023-01-27 14:10       ` Andrei Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126153621.7503a73e@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrei.gherzan@canonical.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).