From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: paulmck@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
corbet@lwn.net, akpm@linux-foundation.org,
ndesaulniers@google.com, vbabka@suse.cz, hannes@cmpxchg.org,
joel@joelfernandes.org, quic_neeraju@quicinc.com,
urezki@gmail.com
Subject: Re: [PATCH RFC bootconfig] Allow forcing unconditional bootconfig processing
Date: Fri, 27 Jan 2023 14:57:31 +0900 [thread overview]
Message-ID: <20230127145731.ece1ada974d305dae3536bd2@kernel.org> (raw)
In-Reply-To: <20230126192614.GA691808@paulmck-ThinkPad-P17-Gen-1>
On Thu, 26 Jan 2023 11:26:14 -0800
"Paul E. McKenney" <paulmck@kernel.org> wrote:
> On Tue, Jan 10, 2023 at 07:02:59AM -0800, Paul E. McKenney wrote:
> > On Tue, Jan 10, 2023 at 11:17:21PM +0900, Masami Hiramatsu wrote:
> > > On Mon, 9 Jan 2023 17:09:53 -0800
> > > "Paul E. McKenney" <paulmck@kernel.org> wrote:
> > >
> > > > On Tue, Jan 10, 2023 at 09:54:50AM +0900, Masami Hiramatsu wrote:
> > > > > On Mon, 9 Jan 2023 16:07:32 -0800
> > > > > "Paul E. McKenney" <paulmck@kernel.org> wrote:
> > > > >
> > > > > > On Tue, Jan 10, 2023 at 08:56:36AM +0900, Masami Hiramatsu wrote:
> > > > > > > On Sun, 8 Jan 2023 20:25:01 -0800
> > > > > > > "Paul E. McKenney" <paulmck@kernel.org> wrote:
> > > > > > >
> > > > > > > > On Sun, Jan 08, 2023 at 03:04:25PM +0900, Masami Hiramatsu wrote:
> > > > > > > > > On Sat, 7 Jan 2023 08:22:02 -0800
> > > > > > > > > "Paul E. McKenney" <paulmck@kernel.org> wrote:
> > > > > > > > >
> > > > > > > > > > On Sun, Jan 08, 2023 at 12:22:15AM +0900, Masami Hiramatsu wrote:
> > > > > > > > > > > On Wed, 4 Jan 2023 16:58:38 -0800
> > > > > > > > > > > "Paul E. McKenney" <paulmck@kernel.org> wrote:
> > > > > > > > > > >
> > > > > > > > > > > > The BOOT_CONFIG family of Kconfig options allows a bootconfig file
> > > > > > > > > > > > containing kernel boot parameters to be embedded into an initrd or into
> > > > > > > > > > > > the kernel itself. This can be extremely useful when deploying kernels
> > > > > > > > > > > > in cases where some of the boot parameters depend on the kernel version
> > > > > > > > > > > > rather than on the server hardware, firmware, or workload.
> > > > > > > > > > > >
> > > > > > > > > > > > Unfortunately, the "bootconfig" kernel parameter must be specified in
> > > > > > > > > > > > order to cause the kernel to look for the embedded bootconfig file,
> > > > > > > > > > > > and it clearly does not help to embed this "bootconfig" kernel parameter
> > > > > > > > > > > > into that file.
> > > > > > > > > > > >
> > > > > > > > > > > > Therefore, provide a new BOOT_CONFIG_FORCE Kconfig option that causes the
> > > > > > > > > > > > kernel to act as if the "bootconfig" kernel parameter had been specified.
> > > > > > > > > > > > In other words, kernels built with CONFIG_BOOT_CONFIG_FORCE=y will look
> > > > > > > > > > > > for the embedded bootconfig file even when the "bootconfig" kernel
> > > > > > > > > > > > parameter is omitted. This permits kernel-version-dependent kernel
> > > > > > > > > > > > boot parameters to be embedded into the kernel image without the need to
> > > > > > > > > > > > (for example) update large numbers of boot loaders.
> > > > > > > > > > >
> > > > > > > > > > > I like this because this is a simple solution. We have another option
> > > > > > > > > > > to specify "bootconfig" in CONFIG_CMDLINE, but it can be overwritten by
> > > > > > > > > > > bootloader. Thus, it is better to have this option so that user can
> > > > > > > > > > > always enable bootconfig.
> > > > > > > > > >
> > > > > > > > > > Glad you like it!
> > > > > > > > > >
> > > > > > > > > > In addition, if the help text is accurate, another shortcoming of
> > > > > > > > > > CONFIG_CMDLINE is that its semantics vary from one architecture to
> > > > > > > > > > another. Some have CONFIG_CMDLINE override the boot-loader supplied
> > > > > > > > > > parameters, and others differ in the order in which the parameters
> > > > > > > > > > are processed.
> > > > > > > > >
> > > > > > > > > Yes, that differences confuse us...
> > > > > > > >
> > > > > > > > I am glad that it is not just me. ;-)
> > > > > > > >
> > > > > > > > I will add words to that effect to the commit log.
> > > > > > > >
> > > > > > > > > > > Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > > > > > > > > >
> > > > > > > > > > Thank you!
> > > > > > > > > >
> > > > > > > > > > > BTW, maybe CONFIG_BOOT_CONFIG_EMBED is better to select this.
> > > > > > > > > > > (or at least recommend to enable this)
> > > > > > > > > >
> > > > > > > > > > Like this?
> > > > > > > > >
> > > > > > > > > Yes! Thanks.
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > Thanx, Paul
> > > > > > > > > >
> > > > > > > > > > ------------------------------------------------------------------------
> > > > > > > > > >
> > > > > > > > > > commit d09a1505c51a70da38b34ac38062977299aef742
> > > > > > > > > > Author: Paul E. McKenney <paulmck@kernel.org>
> > > > > > > > > > Date: Sat Jan 7 08:09:22 2023 -0800
> > > > > > > > > >
> > > > > > > > > > bootconfig: Default BOOT_CONFIG_FORCE to y if BOOT_CONFIG_EMBED
> > > > > > > > > >
> > > > > > > > > > When a kernel is built with CONFIG_BOOT_CONFIG_EMBED=y, the intention
> > > > > > > > > > will normally be to unconditionally provide the specified kernel-boot
> > > > > > > > > > arguments to the kernel, as opposed to requiring a separately provided
> > > > > > > > > > bootconfig parameter. Therefore, make the BOOT_CONFIG_FORCE Kconfig
> > > > > > > > > > option default to y in kernels built with CONFIG_BOOT_CONFIG_EMBED=y.
> > > > > > > > > >
> > > > > > > > > > The old semantics may be obtained by manually overriding this default.
> > > > > > > > > >
> > > > > > > > > > Suggested-by: Masami Hiramatsu <mhiramat@kernel.org>
> > > > > > > > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > > > > > > > >
> > > > > > > > > Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > > > > > > >
> > > > > > > > Applied, thank you!
> > > > > > >
> > > > > > > Paul, just for confirmation, have you picked these patches on your tree?
> > > > > >
> > > > > > I have, but if you would prefer to take them, just let me know when you
> > > > > > have pulled them in. It is easy for me to drop them.
> > > > > >
> > > > > > Here they are in the -rcu tree:
> > > > > >
> > > > > > 3d9ccc4a8b56e bootconfig: Allow forcing unconditional bootconfig processing
> > > > > > 68b920592ff67 bootconfig: Default BOOT_CONFIG_FORCE to y if BOOT_CONFIG_EMBED
> > > > > >
> > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> > > > >
> > > > > Yeah, if it's not hurry, let me pick those to linux-trace tree
> > > > > (bootconfig/for-next). I would like to consolidate the bootconfig
> > > > > updates on my tree.
> > > >
> > > > Please go ahead and grab them. Just out of curiosity, are they in time
> > > > for the upcoming v6.3 merge window?
> > >
> > > Yes, I will do.
> >
> > Very good, I will drop them from my tree on my next rebase.
>
> Apologies for nagging, but I don't see this in -next, so I figured that
> I should follow up. Is there some adjustment required to this patch?
> If so, please let me know so that I can fix it.
Thanks for following up!
Sorry, it was my mistake to forget it to -next. Let me fix that.
>
> Thanx, Paul
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-01-27 5:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 0:58 [PATCH RFC bootconfig] Allow forcing unconditional bootconfig processing Paul E. McKenney
2023-01-07 15:22 ` Masami Hiramatsu
2023-01-07 16:22 ` Paul E. McKenney
2023-01-08 6:04 ` Masami Hiramatsu
2023-01-09 4:25 ` Paul E. McKenney
2023-01-09 23:56 ` Masami Hiramatsu
2023-01-10 0:07 ` Paul E. McKenney
2023-01-10 0:54 ` Masami Hiramatsu
2023-01-10 1:09 ` Paul E. McKenney
2023-01-10 14:17 ` Masami Hiramatsu
2023-01-10 15:02 ` Paul E. McKenney
2023-01-26 19:26 ` Paul E. McKenney
2023-01-27 5:57 ` Masami Hiramatsu [this message]
2023-01-31 18:50 ` Paul E. McKenney
2023-02-24 8:31 ` Geert Uytterhoeven
2023-02-24 16:13 ` Masami Hiramatsu
2023-02-24 16:33 ` Paul E. McKenney
2023-02-25 0:58 ` Masami Hiramatsu
2023-02-25 1:19 ` Paul E. McKenney
2023-02-26 23:16 ` Masami Hiramatsu
2023-02-27 16:56 ` Paul E. McKenney
2023-02-27 23:29 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127145731.ece1ada974d305dae3536bd2@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=joel@joelfernandes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).