From: Jonathan Cameron <jic23@kernel.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: error27@gmail.com, Lars-Peter Clausen <lars@metafoo.de>,
Irina Tirdea <irina.tirdea@intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()
Date: Sat, 28 Jan 2023 17:42:27 +0000 [thread overview]
Message-ID: <20230128174227.7c240576@jic23-huawei> (raw)
In-Reply-To: <20230126153610.3586243-1-harshit.m.mogalapalli@oracle.com>
On Thu, 26 Jan 2023 07:36:09 -0800
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:
> Smatch Warns:
> drivers/iio/accel/mma9551_core.c:299
> mma9551_read_config_word() error: uninitialized symbol 'v'.
>
> When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
> without 'v' being initialized, so check for the error and return.
>
> Fixes: 40cb761306d6 ("iio: add driver for Freescale MMA9553")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Similar to previous. It's tidying up an inelegant bit of code, but no
actual bug due to checks at the caller. Hence I've dropped the fixes
tag and added a note to the commit description for anyone considering backporting.
Applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a look at it and see if we missed anything.
Thanks,
Jonathan
> ---
> This is detected using static analysis.
> ---
> drivers/iio/accel/mma9551_core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma9551_core.c b/drivers/iio/accel/mma9551_core.c
> index 64ca7d7a9673..75eee7f7303a 100644
> --- a/drivers/iio/accel/mma9551_core.c
> +++ b/drivers/iio/accel/mma9551_core.c
> @@ -296,9 +296,12 @@ int mma9551_read_config_word(struct i2c_client *client, u8 app_id,
>
> ret = mma9551_transfer(client, app_id, MMA9551_CMD_READ_CONFIG,
> reg, NULL, 0, (u8 *)&v, 2);
> + if (ret < 0)
> + return ret;
> +
> *val = be16_to_cpu(v);
>
> - return ret;
> + return 0;
> }
> EXPORT_SYMBOL_NS(mma9551_read_config_word, IIO_MMA9551);
>
prev parent reply other threads:[~2023-01-28 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 15:36 [PATCH] iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word() Harshit Mogalapalli
2023-01-28 17:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230128174227.7c240576@jic23-huawei \
--to=jic23@kernel.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=irina.tirdea@intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).