From: Andrew Morton <akpm@linux-foundation.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Uladzislau Rezki <urezki@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set
Date: Sun, 29 Jan 2023 13:41:47 -0800 [thread overview]
Message-ID: <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> (raw)
In-Reply-To: <b93ec55c-f6f0-274a-e7d6-edb419b4be8a@huawei.com>
On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin <liushixin2@huawei.com> wrote:
> Hi,
>
>
> This patch seems to have been lost in the corner. Recently I've meet this problem again
>
> on v6.1, so I would like to propose this patch again.
>
>
> Thanks,
>
>
> On 2022/12/27 17:26, Liu Shixin wrote:
> > After I add a 10GB pmem device, I got the following error message when
> > insert module:
> >
> > insmod: vmalloc error: size 16384, vm_struct allocation failed,
> > mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0
> >
> > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the
> > vmalloc region entirely. Although module_alloc() can fall back to a 2GB
> > window if ARM64_MODULE_PLTS is set, the module region is still easily
> > exhausted because the module region is located at bottom of vmalloc region
> > and the vmalloc region is allocated from bottom to top.
> >
> > Skip module region if not calling from module_alloc().
> >
I'll assume this is for the arm tree.
Acked-by: Andrew Morton <akpm@linux-foundation.org>
next prev parent reply other threads:[~2023-01-29 21:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 9:26 [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set Liu Shixin
2023-01-29 2:44 ` Liu Shixin
2023-01-29 21:41 ` Andrew Morton [this message]
2023-01-31 15:06 ` Will Deacon
2023-01-31 15:07 ` Will Deacon
2023-01-31 16:03 ` Ard Biesheuvel
2023-02-03 8:56 ` Liu Shixin
2023-02-07 11:29 ` Will Deacon
2023-02-27 15:08 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-27 16:14 ` Ard Biesheuvel
2023-02-27 17:17 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-27 17:53 ` Ard Biesheuvel
2023-02-28 1:48 ` Liu Shixin
2023-02-28 1:46 ` Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).