From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: openbmc@lists.ozlabs.org
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Joel Stanley" <joel@jms.id.au>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] soc: nuvoton: Fix Kconfig
Date: Sun, 12 Feb 2023 22:52:31 +0100 [thread overview]
Message-ID: <20230212215234.2608565-1-j.neuschaefer@gmx.net> (raw)
Unfortunately, version 5 of the Nuvoton WPCM450 SoC driver was applied
to bmc.git, which misses a few fixes that were in version 6.
This patch adds the missing fixes:
- Add a menu "Nuvoton SoC drivers" to make it easier to add other
Nuvoton SoC drivers later on and to prevent asking about the Nuvoton
WPCM450 SoC driver when configuring a kernel without support for
Nuvoton SoCs.
- Select CONFIG_REGMAP from CONFIG_WPCM450_SOC, because the driver
relies on regmap to work.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/lkml/CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com/
Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v2:
- Commit message improvements, as suggested by Geert Uytterhoeven.
- Add Link after Reviewed-by, as checkpatch.pl now suggests
---
drivers/soc/nuvoton/Kconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
index df46182088ec2..2167d3d739d84 100644
--- a/drivers/soc/nuvoton/Kconfig
+++ b/drivers/soc/nuvoton/Kconfig
@@ -1,11 +1,17 @@
# SPDX-License-Identifier: GPL-2.0
-menuconfig WPCM450_SOC
+menu "Nuvoton SoC drivers"
+ depends on ARCH_NPCM || COMPILE_TEST
+
+config WPCM450_SOC
tristate "Nuvoton WPCM450 SoC driver"
default y if ARCH_WPCM450
select SOC_BUS
+ select REGMAP
help
Say Y here to compile the SoC information driver for Nuvoton
WPCM450 SoCs.
This driver provides information such as the SoC model and
revision.
+
+endmenu
--
2.39.1
reply other threads:[~2023-02-12 21:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230212215234.2608565-1-j.neuschaefer@gmx.net \
--to=j.neuschaefer@gmx.net \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).