From: kernel test robot <lkp@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 09/17] thermal: Add a thermal zone id accessor
Date: Mon, 20 Feb 2023 01:15:10 +0800 [thread overview]
Message-ID: <202302200137.srsrI6dW-lkp@intel.com> (raw)
In-Reply-To: <20230219143657.241542-10-daniel.lezcano@linaro.org>
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on next-20230217]
[cannot apply to groeck-staging/hwmon-next tegra/for-next linus/master v6.2-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-core-Add-a-thermal-zone-devdata-accessor/20230219-224155
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20230219143657.241542-10-daniel.lezcano%40linaro.org
patch subject: [PATCH v1 09/17] thermal: Add a thermal zone id accessor
config: csky-randconfig-r005-20230219 (https://download.01.org/0day-ci/archive/20230220/202302200137.srsrI6dW-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/37b2cf4cee949fd910b54e281577cb71b2df8842
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Add-a-thermal-zone-devdata-accessor/20230219-224155
git checkout 37b2cf4cee949fd910b54e281577cb71b2df8842
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash drivers/hwmon/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302200137.srsrI6dW-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/hwmon/scmi-hwmon.c: In function 'scmi_hwmon_thermal_get_temp':
drivers/hwmon/scmi-hwmon.c:144:49: error: implicit declaration of function 'thermal_zone_device_get_data'; did you mean 'thermal_zone_device_enable'? [-Werror=implicit-function-declaration]
144 | struct scmi_thermal_sensor *th_sensor = thermal_zone_device_get_data(tz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| thermal_zone_device_enable
drivers/hwmon/scmi-hwmon.c:144:49: warning: initialization of 'struct scmi_thermal_sensor *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
In file included from include/linux/device.h:15,
from include/linux/scmi_protocol.h:12,
from drivers/hwmon/scmi-hwmon.c:11:
drivers/hwmon/scmi-hwmon.c: In function 'scmi_thermal_sensor_register':
>> drivers/hwmon/scmi-hwmon.c:223:39: error: implicit declaration of function 'thermal_zone_device_get_id'; did you mean 'thermal_zone_device_enable'? [-Werror=implicit-function-declaration]
223 | sensor->name, thermal_zone_device_get_id(tzd));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk'
129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/hwmon/scmi-hwmon.c:222:17: note: in expansion of macro 'dev_dbg'
222 | dev_dbg(dev, "Sensor '%s' attached to thermal zone ID:%d\n",
| ^~~~~~~
cc1: some warnings being treated as errors
vim +223 drivers/hwmon/scmi-hwmon.c
138
139 static int scmi_hwmon_thermal_get_temp(struct thermal_zone_device *tz,
140 int *temp)
141 {
142 int ret;
143 long value;
> 144 struct scmi_thermal_sensor *th_sensor = thermal_zone_device_get_data(tz);
145
146 ret = scmi_hwmon_read_scaled_value(th_sensor->ph, th_sensor->info,
147 &value);
148 if (!ret)
149 *temp = value;
150
151 return ret;
152 }
153
154 static const struct thermal_zone_device_ops scmi_hwmon_thermal_ops = {
155 .get_temp = scmi_hwmon_thermal_get_temp,
156 };
157
158 static int scmi_hwmon_add_chan_info(struct hwmon_channel_info *scmi_hwmon_chan,
159 struct device *dev, int num,
160 enum hwmon_sensor_types type, u32 config)
161 {
162 int i;
163 u32 *cfg = devm_kcalloc(dev, num + 1, sizeof(*cfg), GFP_KERNEL);
164
165 if (!cfg)
166 return -ENOMEM;
167
168 scmi_hwmon_chan->type = type;
169 scmi_hwmon_chan->config = cfg;
170 for (i = 0; i < num; i++, cfg++)
171 *cfg = config;
172
173 return 0;
174 }
175
176 static enum hwmon_sensor_types scmi_types[] = {
177 [TEMPERATURE_C] = hwmon_temp,
178 [VOLTAGE] = hwmon_in,
179 [CURRENT] = hwmon_curr,
180 [POWER] = hwmon_power,
181 [ENERGY] = hwmon_energy,
182 };
183
184 static u32 hwmon_attributes[hwmon_max] = {
185 [hwmon_temp] = HWMON_T_INPUT | HWMON_T_LABEL,
186 [hwmon_in] = HWMON_I_INPUT | HWMON_I_LABEL,
187 [hwmon_curr] = HWMON_C_INPUT | HWMON_C_LABEL,
188 [hwmon_power] = HWMON_P_INPUT | HWMON_P_LABEL,
189 [hwmon_energy] = HWMON_E_INPUT | HWMON_E_LABEL,
190 };
191
192 static int scmi_thermal_sensor_register(struct device *dev,
193 const struct scmi_protocol_handle *ph,
194 const struct scmi_sensor_info *sensor)
195 {
196 struct scmi_thermal_sensor *th_sensor;
197 struct thermal_zone_device *tzd;
198
199 th_sensor = devm_kzalloc(dev, sizeof(*th_sensor), GFP_KERNEL);
200 if (!th_sensor)
201 return -ENOMEM;
202
203 th_sensor->ph = ph;
204 th_sensor->info = sensor;
205
206 /*
207 * Try to register a temperature sensor with the Thermal Framework:
208 * skip sensors not defined as part of any thermal zone (-ENODEV) but
209 * report any other errors related to misconfigured zones/sensors.
210 */
211 tzd = devm_thermal_of_zone_register(dev, th_sensor->info->id, th_sensor,
212 &scmi_hwmon_thermal_ops);
213 if (IS_ERR(tzd)) {
214 devm_kfree(dev, th_sensor);
215
216 if (PTR_ERR(tzd) != -ENODEV)
217 return PTR_ERR(tzd);
218
219 dev_dbg(dev, "Sensor '%s' not attached to any thermal zone.\n",
220 sensor->name);
221 } else {
222 dev_dbg(dev, "Sensor '%s' attached to thermal zone ID:%d\n",
> 223 sensor->name, thermal_zone_device_get_id(tzd));
224 }
225
226 return 0;
227 }
228
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-19 17:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 14:36 [PATCH v1 00/17] Self-encapsulate the thermal zone device structure Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 01/17] thermal/core: Add a thermal zone 'devdata' accessor Daniel Lezcano
2023-02-19 14:56 ` Guenter Roeck
2023-02-19 15:07 ` Niklas Söderlund
2023-02-19 17:07 ` Daniel Lezcano
2023-02-19 18:23 ` Niklas Söderlund
2023-02-19 16:23 ` kernel test robot
2023-02-19 22:34 ` Mark Brown
2023-02-20 8:20 ` Ido Schimmel
2023-02-20 9:09 ` AngeloGioacchino Del Regno
2023-02-20 10:34 ` Balsam CHIHI
2023-02-20 10:37 ` Greenman, Gregory
2023-02-20 11:03 ` DLG Adam Ward
2023-02-20 12:18 ` Geert Uytterhoeven
2023-02-20 14:48 ` DLG Adam Ward
2023-02-20 11:13 ` Baolin Wang
2023-02-20 13:23 ` Sebastian Reichel
2023-02-19 14:36 ` [PATCH v1 02/17] thermal/core: Show a debug message when get_temp() fails Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 03/17] thermal: Remove debug or error messages in get_temp() ops Daniel Lezcano
2023-02-20 8:58 ` Miquel Raynal
2023-02-19 14:36 ` [PATCH v1 04/17] thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-19 15:08 ` Niklas Söderlund
2023-02-19 14:36 ` [PATCH v1 05/17] thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-19 17:26 ` Martin Blumenstingl
2023-02-19 14:36 ` [PATCH v1 06/17] thermal: Don't use 'device' internal thermal zone structure field Daniel Lezcano
2023-02-20 10:50 ` Balsam CHIHI
2023-02-19 14:36 ` [PATCH v1 07/17] thermal/hwmon: Use the thermal API instead tampering the internals Daniel Lezcano
2023-02-20 13:34 ` Daniel Lezcano
2023-02-20 14:11 ` Guenter Roeck
2023-02-20 15:39 ` Daniel Lezcano
2023-02-20 17:12 ` Guenter Roeck
2023-02-21 16:08 ` Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 08/17] thermal/drivers/spear: Don't use tz->device but pdev->dev Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 09/17] thermal: Add a thermal zone id accessor Daniel Lezcano
2023-02-19 14:55 ` Guenter Roeck
2023-02-19 17:15 ` kernel test robot [this message]
2023-02-19 14:36 ` [PATCH v1 10/17] thermal: Do not access 'type' field, use the tz id instead Daniel Lezcano
2023-02-20 8:22 ` Ido Schimmel
2023-02-19 14:36 ` [PATCH v1 11/17] thermal/drivers/da9062: Don't access the thermal zone device fields Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 12/17] thermal/hwmon: Use the thermal_core.h header Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 13/17] thermal/drivers/tegra: Remove unneeded lock when setting a trip point Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 14/17] thermal/tegra: Do not enable the thermal zone, it is already enabled Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 15/17] thermal/drivers/acerhdf: Make interval setting only at module load time Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 16/17] thermal/drivers/acerhdf: Remove pointless governor test Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 17/17] thermal/traces: Replace the thermal zone structure parameter with the field value Daniel Lezcano
2023-02-19 21:35 ` [PATCH v1 16/17] thermal/drivers/acerhdf: Remove pointless governor test Peter Kästle
2023-02-19 21:38 ` [PATCH v1 15/17] thermal/drivers/acerhdf: Make interval setting only at module load time Peter Kästle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302200137.srsrI6dW-lkp@intel.com \
--to=lkp@intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).