linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Orlando Chamberlain <orlandoch.dev@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-input@vger.kernel.org,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-kernel@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
	"Aditya Garg" <gargaditya08@live.com>,
	"Aun-Ali Zaidi" <admin@kodeit.net>,
	"Kerem Karabay" <kekrby@gmail.com>,
	"Thomas Weißschuh" <thomas@t-8ch.de>,
	"Thomas Weißschuh" <linux@weissschuh.net>
Subject: Re: [PATCH v4 2/2] HID: hid-apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards
Date: Mon, 20 Feb 2023 22:45:00 +1100	[thread overview]
Message-ID: <20230220224500.0486bc3b@redecorated-mbp> (raw)
In-Reply-To: <Y/NZm22JQKeF1+6R@smile.fi.intel.com>

On Mon, 20 Feb 2023 13:29:31 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, Feb 20, 2023 at 06:09:32PM +1100, Orlando Chamberlain wrote:
> > On Sun, 19 Feb 2023 16:09:26 +0200
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:  
> > > On Sat, Feb 18, 2023 at 11:08 AM Orlando Chamberlain
> > > <orlandoch.dev@gmail.com> wrote:  
> 
> ...
> 
> > > > +       help
> > > > +       Say Y here if you want support for the keyboard
> > > > backlight on Macs with
> > > > +       the magic keyboard (MacBookPro16,x and MacBookAir9,1).
> > > > Note that this
> > > > +       driver is not for external magic keyboards.
> > > > +
> > > > +       To compile this driver as a module, choose M here: the
> > > > +       module will be called hid-apple-magic-backlight.    
> > > 
> > > Is it my email client or is the indentation of the help text
> > > incorrect?
> > > 
> > > Hint: the text of the help should be <TAB><SPACE><SPACE> indented.
> > > 
> > > I believe checkpatch.pl at least in --strict mode should complain
> > > about this.  
> > 
> > Looking at the hid Kconfig, it seems like some have it as you've
> > described, and some just have tab (and a few have just tab for the
> > first line, and tab space space for the rest of the lines).  
> 
> Okay, I have checked in the other MUA I'm using for patch reviews and
> indeed your Kconfig indentation is broken.
> 
> > checkpatch.pl --strict didn't complain about the indentation so
> > hopefully it's alright as is.  
> 
> No, it's not. Must be fixed.
> 
> https://www.kernel.org/doc/html/latest/process/coding-style.html#kconfig-configuration-files
> 

No worries, I'll fix that in v5.

  reply	other threads:[~2023-02-20 11:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18  9:07 [PATCH v4 0/2] Apple Magic Keyboard Backlight Orlando Chamberlain
2023-02-18  9:07 ` [PATCH v4 1/2] Documentation: leds: standardise keyboard backlight led names Orlando Chamberlain
2023-02-18  9:07 ` [PATCH v4 2/2] HID: hid-apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards Orlando Chamberlain
2023-02-19 14:09   ` Andy Shevchenko
2023-02-20  7:09     ` Orlando Chamberlain
2023-02-20 11:29       ` Andy Shevchenko
2023-02-20 11:45         ` Orlando Chamberlain [this message]
2023-02-20  8:33   ` Aditya Garg
2023-02-20 11:45     ` Orlando Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230220224500.0486bc3b@redecorated-mbp \
    --to=orlandoch.dev@gmail.com \
    --cc=admin@kodeit.net \
    --cc=andy.shevchenko@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=corbet@lwn.net \
    --cc=gargaditya08@live.com \
    --cc=jikos@kernel.org \
    --cc=kekrby@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=pavel@ucw.cz \
    --cc=thomas@t-8ch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).