From: kernel test robot <lkp@intel.com>
To: Nitesh Shetty <nj.shetty@samsung.com>,
Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: oe-kbuild-all@lists.linux.dev, bvanassche@acm.org, hare@suse.de,
ming.lei@redhat.com, damien.lemoal@opensource.wdc.com,
anuj20.g@samsung.com, joshi.k@samsung.com,
nitheshshetty@gmail.com, gost.dev@samsung.com,
Nitesh Shetty <nj.shetty@samsung.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 4/8] fs, block: copy_file_range for def_blk_ops for direct block device.
Date: Mon, 20 Feb 2023 23:18:00 +0800 [thread overview]
Message-ID: <202302202321.zfUe705N-lkp@intel.com> (raw)
In-Reply-To: <20230220105336.3810-5-nj.shetty@samsung.com>
Hi Nitesh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on device-mapper-dm/for-next]
[also build test WARNING on linus/master v6.2 next-20230220]
[cannot apply to axboe-block/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nitesh-Shetty/block-Add-copy-offload-support-infrastructure/20230220-205057
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
patch link: https://lore.kernel.org/r/20230220105336.3810-5-nj.shetty%40samsung.com
patch subject: [PATCH v7 4/8] fs, block: copy_file_range for def_blk_ops for direct block device.
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20230220/202302202321.zfUe705N-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0f95ad2cb727ac6ac8406a01ff216d9237b403b7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Nitesh-Shetty/block-Add-copy-offload-support-infrastructure/20230220-205057
git checkout 0f95ad2cb727ac6ac8406a01ff216d9237b403b7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302202321.zfUe705N-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> block/fops.c:614:9: warning: no previous prototype for 'blkdev_copy_file_range' [-Wmissing-prototypes]
614 | ssize_t blkdev_copy_file_range(struct file *file_in, loff_t pos_in,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/blkdev_copy_file_range +614 block/fops.c
613
> 614 ssize_t blkdev_copy_file_range(struct file *file_in, loff_t pos_in,
615 struct file *file_out, loff_t pos_out,
616 size_t len, unsigned int flags)
617 {
618 struct block_device *in_bdev = I_BDEV(bdev_file_inode(file_in));
619 struct block_device *out_bdev = I_BDEV(bdev_file_inode(file_out));
620 int comp_len;
621
622 comp_len = blkdev_copy_offload(in_bdev, pos_in, out_bdev, pos_out, len,
623 NULL, NULL, GFP_KERNEL);
624 if (comp_len != len)
625 comp_len = generic_copy_file_range(file_in, pos_in + comp_len,
626 file_out, pos_out + comp_len, len - comp_len, flags);
627
628 return comp_len;
629 }
630
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-20 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230220105423epcas5p4618b6fa4fadde27086180841be87638b@epcas5p4.samsung.com>
2023-02-20 10:53 ` [PATCH v7 0/8] Implement copy offload support Nitesh Shetty
[not found] ` <CGME20230220105432epcas5p2dc91dbe3588d8f45bf312bde2683791a@epcas5p2.samsung.com>
2023-02-20 10:53 ` [PATCH v7 1/8] block: Introduce queue limits for copy-offload support Nitesh Shetty
[not found] ` <CGME20230220105441epcas5p49ffde763aae06db301804175e85f9472@epcas5p4.samsung.com>
2023-02-20 10:53 ` [PATCH v7 2/8] block: Add copy offload support infrastructure Nitesh Shetty
2023-02-21 23:58 ` Minwoo Im
2023-02-22 6:12 ` Nitesh Shetty
[not found] ` <CGME20230220105453epcas5p32b30be5c5b4b21fe0bd4500a560b2b9b@epcas5p3.samsung.com>
2023-02-20 10:53 ` [PATCH v7 3/8] block: add emulation for copy Nitesh Shetty
[not found] ` <CGME20230220105503epcas5p2cb05eb671de6954b7604e49ebd23ce41@epcas5p2.samsung.com>
2023-02-20 10:53 ` [PATCH v7 4/8] fs, block: copy_file_range for def_blk_ops for direct block device Nitesh Shetty
2023-02-20 15:18 ` kernel test robot [this message]
2023-02-20 21:56 ` kernel test robot
2023-02-20 22:27 ` kernel test robot
[not found] ` <CGME20230220105512epcas5p15e1171c05e5ceda614d4f196672ad678@epcas5p1.samsung.com>
2023-02-20 10:53 ` [PATCH v7 5/8] nvme: add copy offload support Nitesh Shetty
[not found] ` <CGME20230220105520epcas5p34fe94decec6573d9b7b3df5df9286ef7@epcas5p3.samsung.com>
2023-02-20 10:53 ` [PATCH v7 6/8] nvmet: add copy command support for bdev and file ns Nitesh Shetty
[not found] ` <CGME20230220105529epcas5p447cd449f13da54794e391b78bd1f5956@epcas5p4.samsung.com>
2023-02-20 10:53 ` [PATCH v7 7/8] dm: Add support for copy offload Nitesh Shetty
[not found] ` <CGME20230220105537epcas5p386dd5c28197f055a8c548cca109d913c@epcas5p3.samsung.com>
2023-02-20 10:53 ` [PATCH v7 8/8] dm: Enable copy offload for dm-linear target Nitesh Shetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302202321.zfUe705N-lkp@intel.com \
--to=lkp@intel.com \
--cc=agk@redhat.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).