From: Guenter Roeck <linux@roeck-us.net>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
intel-wired-lan@lists.osuosl.org, regressions@lists.linux.dev
Subject: Re: [PATCH net-next v8 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv()
Date: Tue, 28 Feb 2023 10:43:03 -0800 [thread overview]
Message-ID: <20230228184303.GA4098978@roeck-us.net> (raw)
In-Reply-To: <20230224172004.GA1224760@roeck-us.net>
Letting regzbot know about the fix:
#regzbot fixed-by: 972074ea8840
On Fri, Feb 24, 2023 at 09:20:04AM -0800, Guenter Roeck wrote:
> Copying regzbot.
>
> #regzbot ^introduced 9b01c885be36
> #regzbot title Network interface initialization failures on xtensa, arm:cubieboard
> #regzbot ignore-activity
>
> On Thu, Feb 23, 2023 at 08:16:06PM -0800, Guenter Roeck wrote:
> > On Thu, Feb 23, 2023 at 07:55:55PM -0800, Guenter Roeck wrote:
> > > On Sat, Feb 11, 2023 at 08:41:10AM +0100, Oleksij Rempel wrote:
> > > > Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv().
> > > >
> > > > It should work as before except write operation to the EEE adv registers
> > > > will be done only if some EEE abilities was detected.
> > > >
> > > > If some driver will have a regression, related driver should provide own
> > > > .get_features callback. See micrel.c:ksz9477_get_features() as example.
> > > >
> > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > >
> > > This patch causes network interface failures with all my xtensa qemu
> > > emulations. Reverting it fixes the problem. Bisect log is attached
> > > for reference.
> > >
> >
> > Also affected are arm:cubieboard emulations, with same symptom.
> > arm:bletchley-bmc emulations crash. In both cases, reverting this patch
> > fixes the problem.
> >
> > Guenter
next prev parent reply other threads:[~2023-02-28 18:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 7:41 [PATCH net-next v8 0/9] net: add EEE support for KSZ9477 switch family Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 1/9] net: dsa: microchip: enable EEE support Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 2/9] net: phy: add genphy_c45_read_eee_abilities() function Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 3/9] net: phy: micrel: add ksz9477_get_features() Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 4/9] net: phy: export phy_check_valid() function Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support Oleksij Rempel
2023-02-26 18:06 ` Mark Brown
2023-02-27 5:52 ` Oleksij Rempel
2023-02-27 13:06 ` Mark Brown
2023-02-27 18:49 ` Jakub Kicinski
2023-02-11 7:41 ` [PATCH net-next v8 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv() Oleksij Rempel
2023-02-24 3:55 ` Guenter Roeck
2023-02-24 4:16 ` Guenter Roeck
2023-02-24 4:53 ` Oleksij Rempel
2023-02-24 16:00 ` Guenter Roeck
2023-02-24 16:52 ` Oleksij Rempel
2023-02-24 17:41 ` Guenter Roeck
2023-02-24 18:36 ` Oleksij Rempel
2023-02-24 19:17 ` Guenter Roeck
2023-02-24 20:02 ` Oleksij Rempel
2023-02-25 0:09 ` Guenter Roeck
2023-02-25 6:08 ` Oleksij Rempel
2023-02-25 6:32 ` Guenter Roeck
2023-02-27 13:08 ` Andrew Lunn
2023-02-27 17:03 ` Guenter Roeck
2023-02-24 17:20 ` Guenter Roeck
2023-02-28 18:43 ` Guenter Roeck [this message]
2023-02-11 7:41 ` [PATCH net-next v8 7/9] net: phy: c45: " Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 8/9] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active() Oleksij Rempel
2023-02-11 7:41 ` [PATCH net-next v8 9/9] net: phy: start using genphy_c45_ethtool_get/set_eee() Oleksij Rempel
2023-02-13 11:30 ` [PATCH net-next v8 0/9] net: add EEE support for KSZ9477 switch family patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228184303.GA4098978@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=vivien.didelot@gmail.com \
--cc=wei.fang@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).