From: Janne Grunau <j@jannau.net>
To: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Marc Zyngier" <maz@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Sven Peter <sven@svenpeter.dev>,
linux-pci@vger.kernel.org, asahi@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Janne Grunau <j@jannau.net>
Subject: [PATCH v2] PCI: apple: Set only available ports up
Date: Thu, 09 Mar 2023 14:36:24 +0100 [thread overview]
Message-ID: <20230307-apple_pcie_disabled_ports-v2-1-c3bd1fd278a4@jannau.net> (raw)
Fixes following warning inside of_irq_parse_raw() called from the common
PCI device probe path.
/soc/pcie@690000000/pci@1,0 interrupt-map failed, using interrupt-controller
WARNING: CPU: 4 PID: 252 at drivers/of/irq.c:279 of_irq_parse_raw+0x5fc/0x724
...
Call trace:
of_irq_parse_raw+0x5fc/0x724
of_irq_parse_and_map_pci+0x128/0x1d8
pci_assign_irq+0xc8/0x140
pci_device_probe+0x70/0x188
really_probe+0x178/0x418
__driver_probe_device+0x120/0x188
driver_probe_device+0x48/0x22c
__device_attach_driver+0x134/0x1d8
bus_for_each_drv+0x8c/0xd8
__device_attach+0xdc/0x1d0
device_attach+0x20/0x2c
pci_bus_add_device+0x5c/0xc0
pci_bus_add_devices+0x58/0x88
pci_host_probe+0x124/0x178
pci_host_common_probe+0x124/0x198 [pci_host_common]
apple_pcie_probe+0x108/0x16c [pcie_apple]
platform_probe+0xb4/0xdc
This became apparent after disabling unused PCIe ports in the Apple
silicon device trees instead of deleting them.
Use for_each_available_child_of_node instead of for_each_child_of_node
which takes the "status" property into account.
Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net/
Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")
Cc: stable@vger.kernel.org
Reviewed-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Janne Grunau <j@jannau.net>
---
Changes in v2:
- rewritten commit message with more details and corrections
- collected Marc's "Reviewed-by:"
- Link to v1: https://lore.kernel.org/r/20230307-apple_pcie_disabled_ports-v1-1-b32ef91faf19@jannau.net
---
drivers/pci/controller/pcie-apple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index 66f37e403a09..f8670a032f7a 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -783,7 +783,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
cfg->priv = pcie;
INIT_LIST_HEAD(&pcie->ports);
- for_each_child_of_node(dev->of_node, of_port) {
+ for_each_available_child_of_node(dev->of_node, of_port) {
ret = apple_pcie_setup_port(pcie, of_port);
if (ret) {
dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret);
---
base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
change-id: 20230307-apple_pcie_disabled_ports-0c17fb7a4738
Best regards,
--
Janne Grunau <j@jannau.net>
next reply other threads:[~2023-03-09 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 13:36 Janne Grunau [this message]
2023-03-09 14:18 ` [PATCH v2] PCI: apple: Set only available ports up Eric Curtin
2023-03-09 15:19 ` Rob Herring
2023-03-09 16:39 ` Bjorn Helgaas
2023-03-09 19:48 ` Conor Dooley
2023-03-16 9:32 ` Marc Zyngier
2023-03-16 10:47 ` Lorenzo Pieralisi
2023-03-16 11:18 ` Marc Zyngier
2023-03-16 21:22 ` Janne Grunau
2023-03-17 9:12 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307-apple_pcie_disabled_ports-v2-1-c3bd1fd278a4@jannau.net \
--to=j@jannau.net \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).