archive mirror
 help / color / mirror / Atom feed
From: Zheng Wang <>
Cc:,,,,,,, Zheng Wang <>
Subject: [PATCH] memstick: r592: Fix UAF bug in r592_remove due to race condition
Date: Wed,  8 Mar 2023 00:43:38 +0800	[thread overview]
Message-ID: <> (raw)

In r592_probe, dev->detect_timer was bound with r592_detect_timer.
In r592_irq function, the timer function will be invoked by mod_timer.

If we remove the module which will call hantro_release to make cleanup,
there may be a unfinished work. The possible sequence is as follows,
which will cause a typical UAF bug.

Fix it by canceling the work before cleanup in r592_remove.

CPU0                  CPU1

r592_remove         |
  put_device;       |
  kfree(host);      |
                    | queue_work
                    |   &host->media_checker //use

Signed-off-by: Zheng Wang <>
 drivers/memstick/host/r592.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
index 1d35d147552d..2bfa7eaae80a 100644
--- a/drivers/memstick/host/r592.c
+++ b/drivers/memstick/host/r592.c
@@ -829,7 +829,7 @@ static void r592_remove(struct pci_dev *pdev)
 	/* Stop the processing thread.
 	That ensures that we won't take any more requests */
+	del_timer_sync(&dev->detect_timer);
 	r592_enable_device(dev, false);
 	while (!error && dev->req) {

             reply	other threads:[~2023-03-07 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 16:43 Zheng Wang [this message]
2023-03-09 15:02 ` [PATCH] memstick: r592: Fix UAF bug in r592_remove due to race condition Ulf Hansson
2023-03-10 16:20   ` Zheng Hacker
  -- strict thread matches above, loose matches on Subject: below --
2023-03-07 16:42 Zheng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).