Re: [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers

From: Lee Jones <lee@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Pavel Machek <pavel@ucw.cz>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Jonathan Corbet <corbet@lwn.net>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	John Crispin <john@phrozen.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-doc@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Arun.Ramadoss@microchip.com
Subject: Re: [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers
Date: Wed, 8 Mar 2023 14:06:42 +0000	[thread overview]
Message-ID: <20230308140642.GO9667@google.com> (raw)
In-Reply-To: <6406344a.050a0220.693b3.6689@mx.google.com>

On Mon, 06 Mar 2023, Christian Marangi wrote:

> On Wed, Feb 22, 2023 at 03:02:04PM +0000, Lee Jones wrote:
> > On Fri, 17 Feb 2023, Andrew Lunn wrote:
> >
> > > On Thu, Feb 16, 2023 at 02:32:17AM +0100, Christian Marangi wrote:
> > > > This is another attempt on adding this feature on LEDs, hoping this is
> > > > the right time and someone finally notice this.
> > >
> > > Hi Christian
> > >
> > > Thanks for keeping working on this.
> > >
> > > I want to review it, and maybe implement LED support in a PHY
> > > driver. But i'm busy with reworking EEE at the moment.
> > >
> > > The merge window is about to open, so patches are not going to be
> > > accepted for the next two weeks. So i will take a look within that
> > > time and give you feedback.
> >
> > Thanks Andrew.  If Pavel is still unavailable to conduct reviews, I'm
> > going to need all the help I can get with complex submissions such as
> > these.
> >
>
> Hi Lee,
> thanks for stepping in. Just wanted to tell you I got some message with
> Andrew to make this thing less problematic and to dry/make it more
> review friendly.
>
> We decided on pushing this in 3 step:
> 1. Propose most basic things for some switch and some PHY. (brightness
> and blink_set support only, already supported by LED core)
> 2. A small series that should be just a cleanup for the netdev trigger
> 3. Support for hw_control in the most possible clean and way with small
> patch to they are not hard to track and understand the concept of this
> feature.
>
> I'm starting with the step 1 and sending some of my patch and Andrew
> patch to add basic support and I will add you and LED mailing list in
> Cc.

Sounds like a plan.  Thank you both.

> Again thanks for starting checking this and feel free to ask any
> question about this to me also privately, I'm very open to any help.

--
Lee Jones [李琼斯]