From: Peter Zijlstra <peterz@infradead.org>
To: Zhang Qiao <zhangqiao22@huawei.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, rkagan@amazon.de
Subject: Re: [PATCH v2] sched/fair: sanitize vruntime of entity being migrated
Date: Thu, 9 Mar 2023 14:05:24 +0100 [thread overview]
Message-ID: <20230309130524.GA273121@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230306132418.50389-1-zhangqiao22@huawei.com>
On Mon, Mar 06, 2023 at 09:24:18PM +0800, Zhang Qiao wrote:
> Commit 829c1651e9c4 ("sched/fair: sanitize vruntime of
> entity being placed") fix an overflowing bug, but ignore
> a case that se->exec_start is reset after a migration.
>
> For fixing this case, we reset the vruntime of a long
> sleeping task in migrate_task_rq_fair().
>
> @@ -7635,7 +7653,23 @@ static void migrate_task_rq_fair(struct task_struct *p, int new_cpu)
> if (READ_ONCE(p->__state) == TASK_WAKING) {
> struct cfs_rq *cfs_rq = cfs_rq_of(se);
>
> - se->vruntime -= u64_u32_load(cfs_rq->min_vruntime);
> + /*
> + * We determine whether a task sleeps for long by checking
> + * se->exec_start, and if it is, we sanitize its vruntime at
> + * place_entity(). However, after a migration, this detection
> + * method fails due to se->exec_start being reset.
> + *
> + * For fixing this case, we add the same check here. For a task
> + * which has slept for a long time, its vruntime should be reset
> + * to cfs_rq->min_vruntime with a sleep credit. Because waking
> + * task's vruntime will be added to cfs_rq->min_vruntime when
> + * enqueue, we only need to reset the se->vruntime of waking task
> + * to a credit here.
> + */
> + if (entity_is_long_sleep(se))
> + se->vruntime = -sched_sleeper_credit(se);
> + else
> + se->vruntime -= u64_u32_load(cfs_rq->min_vruntime);
> }
*groan*, that again...
Can't we simply do:
https://lkml.kernel.org/r/68832dfbb60fda030540b5f4e39c5801942689b1.1648228023.git.tim.c.chen@linux.intel.com
?
next prev parent reply other threads:[~2023-03-09 13:06 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 13:24 [PATCH v2] sched/fair: sanitize vruntime of entity being migrated Zhang Qiao
2023-03-06 13:53 ` Vincent Guittot
2023-03-07 10:26 ` Vincent Guittot
2023-03-07 11:05 ` Zhang Qiao
2023-03-07 13:41 ` Zhang Qiao
2023-03-08 8:01 ` Vincent Guittot
2023-03-08 12:55 ` Vincent Guittot
2023-03-09 8:37 ` Zhang Qiao
2023-03-09 9:09 ` Dietmar Eggemann
2023-03-09 9:30 ` Zhang Qiao
2023-03-09 10:48 ` Vincent Guittot
2023-03-09 14:23 ` Zhang Qiao
2023-03-07 2:16 ` kernel test robot
2023-03-07 12:45 ` Dietmar Eggemann
2023-03-07 14:06 ` Zhang Qiao
2023-03-09 9:43 ` Zhang Qiao
2023-03-08 14:33 ` Chen Yu
2023-03-09 13:05 ` Peter Zijlstra [this message]
2023-03-09 13:34 ` Vincent Guittot
2023-03-09 14:28 ` Peter Zijlstra
2023-03-09 14:36 ` Peter Zijlstra
2023-03-09 15:14 ` Vincent Guittot
2023-03-10 14:29 ` Vincent Guittot
2023-03-11 9:57 ` Zhang Qiao
2023-03-13 14:23 ` Vincent Guittot
2023-03-14 11:03 ` Zhang Qiao
2023-03-14 13:26 ` Vincent Guittot
2023-03-14 13:38 ` Zhang Qiao
2023-03-14 13:39 ` Vincent Guittot
2023-03-14 15:32 ` Vincent Guittot
2023-03-15 9:16 ` Zhang Qiao
2023-03-15 15:30 ` Vincent Guittot
2023-03-13 9:06 ` Dietmar Eggemann
2023-03-13 18:17 ` Dietmar Eggemann
2023-03-14 7:41 ` Vincent Guittot
2023-03-14 12:07 ` Peter Zijlstra
2023-03-14 13:24 ` Vincent Guittot
2023-03-14 17:16 ` Peter Zijlstra
2023-03-15 7:18 ` Vincent Guittot
2023-03-15 8:42 ` Vincent Guittot
2023-03-15 10:15 ` Dietmar Eggemann
2023-03-15 10:21 ` Vincent Guittot
2023-03-15 13:35 ` Dietmar Eggemann
2023-03-15 15:32 ` Vincent Guittot
2023-03-14 13:29 ` Dietmar Eggemann
2023-03-14 13:37 ` Dietmar Eggemann
2023-03-17 16:08 Vincent Guittot
2023-03-18 7:45 ` Zhang Qiao
2023-03-20 12:29 ` Dietmar Eggemann
2023-03-20 13:26 ` Vincent Guittot
2023-03-21 10:02 ` Peter Zijlstra
2023-03-21 10:29 ` Dietmar Eggemann
2023-03-21 10:49 ` Peter Zijlstra
2023-03-21 11:12 ` Vincent Guittot
2023-03-21 11:13 ` Dietmar Eggemann
2023-03-21 12:26 ` Peter Zijlstra
2023-03-21 12:28 ` Peter Zijlstra
2023-03-21 12:38 ` Vincent Guittot
2023-03-24 4:05 ` Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309130524.GA273121@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rkagan@amazon.de \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).