linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mun Yew Tham <mun.yew.tham@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Broadcom internal kernel review list 
	<bcm-kernel-feedback-list@broadcom.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Nandor Han <nandor.han@ge.com>,
	Semi Malinen <semi.malinen@ge.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 4/8] gpio: visconti: drop of_match_ptr for ID table
Date: Sat, 11 Mar 2023 12:13:03 +0100	[thread overview]
Message-ID: <20230311111307.251123-4-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230311111307.251123-1-krzysztof.kozlowski@linaro.org>

The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).

  drivers/gpio/gpio-visconti.c:187:34: error: ‘visconti_gpio_of_match’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpio/gpio-visconti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-visconti.c b/drivers/gpio/gpio-visconti.c
index 5e108ba9956a..10d9de41f29b 100644
--- a/drivers/gpio/gpio-visconti.c
+++ b/drivers/gpio/gpio-visconti.c
@@ -194,7 +194,7 @@ static struct platform_driver visconti_gpio_driver = {
 	.probe		= visconti_gpio_probe,
 	.driver		= {
 		.name	= "visconti_gpio",
-		.of_match_table = of_match_ptr(visconti_gpio_of_match),
+		.of_match_table = visconti_gpio_of_match,
 	}
 };
 module_platform_driver(visconti_gpio_driver);
-- 
2.34.1


  parent reply	other threads:[~2023-03-11 11:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 11:13 [PATCH 1/8] gpio: ftgpio010: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-11 11:13 ` [PATCH 2/8] gpio: altera: " Krzysztof Kozlowski
2023-03-11 21:47   ` Linus Walleij
2023-03-11 11:13 ` [PATCH 3/8] gpio: rcar: " Krzysztof Kozlowski
2023-03-11 21:47   ` Linus Walleij
2023-03-11 11:13 ` Krzysztof Kozlowski [this message]
2023-03-11 21:48   ` [PATCH 4/8] gpio: visconti: " Linus Walleij
2023-03-11 11:13 ` [PATCH 5/8] gpio: sifive: " Krzysztof Kozlowski
2023-03-11 21:48   ` Linus Walleij
2023-03-11 11:13 ` [PATCH 6/8] gpio: sama5d2-piobu: " Krzysztof Kozlowski
2023-03-11 21:49   ` Linus Walleij
2023-03-11 11:13 ` [PATCH 7/8] gpio: xra1403: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 21:49   ` Linus Walleij
2023-03-11 11:13 ` [PATCH 8/8] gpio: raspberrypi-exp: " Krzysztof Kozlowski
2023-03-11 21:49   ` Linus Walleij
2023-03-15 18:36   ` Florian Fainelli
2023-03-11 21:46 ` [PATCH 1/8] gpio: ftgpio010: drop of_match_ptr for ID table Linus Walleij
2023-03-15  9:39 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230311111307.251123-4-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mun.yew.tham@intel.com \
    --cc=nandor.han@ge.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=semi.malinen@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).