From: Alexey Dobriyan <adobriyan@gmail.com>
To: masahiroy@kernel.org
Cc: adobriyan@gmail.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] menuconfig: delete shadows, prepare for vertical space reclaim
Date: Sat, 11 Mar 2023 14:42:46 +0300 [thread overview]
Message-ID: <20230311114248.36587-1-adobriyan@gmail.com> (raw)
Shadows consumes precious vertical lines, simply delete them.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/kconfig/lxdialog/checklist.c | 2 --
scripts/kconfig/lxdialog/dialog.h | 1 -
scripts/kconfig/lxdialog/inputbox.c | 2 --
| 2 --
scripts/kconfig/lxdialog/textbox.c | 2 --
scripts/kconfig/lxdialog/util.c | 22 ----------------------
scripts/kconfig/lxdialog/yesno.c | 2 --
7 files changed, 33 deletions(-)
diff --git a/scripts/kconfig/lxdialog/checklist.c b/scripts/kconfig/lxdialog/checklist.c
index fd161cfff121..7ce5233afaca 100644
--- a/scripts/kconfig/lxdialog/checklist.c
+++ b/scripts/kconfig/lxdialog/checklist.c
@@ -130,8 +130,6 @@ int dialog_checklist(const char *title, const char *prompt, int height,
x = (getmaxx(stdscr) - width) / 2;
y = (getmaxy(stdscr) - height) / 2;
- draw_shadow(stdscr, y, x, height, width);
-
dialog = newwin(height, width, y, x);
keypad(dialog, TRUE);
diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
index 68b565e3c495..50b2674b734d 100644
--- a/scripts/kconfig/lxdialog/dialog.h
+++ b/scripts/kconfig/lxdialog/dialog.h
@@ -206,7 +206,6 @@ void print_button(WINDOW * win, const char *label, int y, int x, int selected);
void print_title(WINDOW *dialog, const char *title, int width);
void draw_box(WINDOW * win, int y, int x, int height, int width, chtype box,
chtype border);
-void draw_shadow(WINDOW * win, int y, int x, int height, int width);
int first_alpha(const char *string, const char *exempt);
int dialog_yesno(const char *title, const char *prompt, int height, int width);
diff --git a/scripts/kconfig/lxdialog/inputbox.c b/scripts/kconfig/lxdialog/inputbox.c
index 1dcfb288ee63..0bda6186a599 100644
--- a/scripts/kconfig/lxdialog/inputbox.c
+++ b/scripts/kconfig/lxdialog/inputbox.c
@@ -52,8 +52,6 @@ int dialog_inputbox(const char *title, const char *prompt, int height, int width
x = (getmaxx(stdscr) - width) / 2;
y = (getmaxy(stdscr) - height) / 2;
- draw_shadow(stdscr, y, x, height, width);
-
dialog = newwin(height, width, y, x);
keypad(dialog, TRUE);
--git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
index 58c2f8afe59b..5c3addad89b0 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -193,8 +193,6 @@ int dialog_menu(const char *title, const char *prompt,
x = (getmaxx(stdscr) - width) / 2;
y = (getmaxy(stdscr) - height) / 2;
- draw_shadow(stdscr, y, x, height, width);
-
dialog = newwin(height, width, y, x);
keypad(dialog, TRUE);
diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
index 4e339b12664e..de965d0770e2 100644
--- a/scripts/kconfig/lxdialog/textbox.c
+++ b/scripts/kconfig/lxdialog/textbox.c
@@ -88,8 +88,6 @@ int dialog_textbox(const char *title, char *tbuf, int initial_height,
x = (getmaxx(stdscr) - width) / 2;
y = (getmaxy(stdscr) - height) / 2;
- draw_shadow(stdscr, y, x, height, width);
-
dialog = newwin(height, width, y, x);
keypad(dialog, TRUE);
diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c
index 3f78fb265136..72dc30e3322d 100644
--- a/scripts/kconfig/lxdialog/util.c
+++ b/scripts/kconfig/lxdialog/util.c
@@ -491,28 +491,6 @@ draw_box(WINDOW * win, int y, int x, int height, int width,
}
}
-/*
- * Draw shadows along the right and bottom edge to give a more 3D look
- * to the boxes
- */
-void draw_shadow(WINDOW * win, int y, int x, int height, int width)
-{
- int i;
-
- if (has_colors()) { /* Whether terminal supports color? */
- wattrset(win, dlg.shadow.atr);
- wmove(win, y + height, x + 2);
- for (i = 0; i < width; i++)
- waddch(win, winch(win) & A_CHARTEXT);
- for (i = y + 1; i < y + height + 1; i++) {
- wmove(win, i, x + width);
- waddch(win, winch(win) & A_CHARTEXT);
- waddch(win, winch(win) & A_CHARTEXT);
- }
- wnoutrefresh(win);
- }
-}
-
/*
* Return the position of the first alphabetic character in a string.
*/
diff --git a/scripts/kconfig/lxdialog/yesno.c b/scripts/kconfig/lxdialog/yesno.c
index bcaac9b7bab2..25e4f10e0e6a 100644
--- a/scripts/kconfig/lxdialog/yesno.c
+++ b/scripts/kconfig/lxdialog/yesno.c
@@ -41,8 +41,6 @@ int dialog_yesno(const char *title, const char *prompt, int height, int width)
x = (getmaxx(stdscr) - width) / 2;
y = (getmaxy(stdscr) - height) / 2;
- draw_shadow(stdscr, y, x, height, width);
-
dialog = newwin(height, width, y, x);
keypad(dialog, TRUE);
--
2.39.2
next reply other threads:[~2023-03-11 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:42 Alexey Dobriyan [this message]
2023-03-11 11:42 ` [PATCH 2/3] menuconfig: reclaim horizontal space Alexey Dobriyan
2023-03-13 0:29 ` Randy Dunlap
2023-03-13 19:27 ` Alexey Dobriyan
2023-03-11 11:42 ` [PATCH 3/3] menuconfig: reclaim vertical space Alexey Dobriyan
2023-03-13 0:29 ` Randy Dunlap
2023-03-21 6:02 ` Masahiro Yamada
2023-03-13 0:29 ` [PATCH 1/3] menuconfig: delete shadows, prepare for vertical space reclaim Randy Dunlap
2023-03-21 5:35 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311114248.36587-1-adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).