From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Robert Eshleman <bobbyeshleman@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: light: max44009: add missing OF device matching
Date: Sat, 11 Mar 2023 12:26:19 +0000 [thread overview]
Message-ID: <20230311122619.2d8bfaf5@jic23-huawei> (raw)
In-Reply-To: <20230311111457.251475-3-krzysztof.kozlowski@linaro.org>
On Sat, 11 Mar 2023 12:14:56 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> The driver currently matches only via i2c_device_id, but also has
> of_device_id table:
>
> drivers/iio/light/max44009.c:545:34: error: ‘max44009_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Fixes: 6aef699a7d7e ("iio: light: add driver for MAX44009")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Don't use of_match_ptr() unless you are absolutely sure no other firmware
route will make use of the of_match_table.
In this particular case ACPI using PRP0001 is broken by that macro.
So good to set the of_match_table, but make sure to always set it
and hence you don't need the __maybe_unused.
Jonathan
> ---
> drivers/iio/light/max44009.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/light/max44009.c b/drivers/iio/light/max44009.c
> index 3dadace09fe2..274e0b679ca2 100644
> --- a/drivers/iio/light/max44009.c
> +++ b/drivers/iio/light/max44009.c
> @@ -527,6 +527,12 @@ static int max44009_probe(struct i2c_client *client)
> return devm_iio_device_register(&client->dev, indio_dev);
> }
>
> +static const struct of_device_id max44009_of_match[] __maybe_unused = {
> + { .compatible = "maxim,max44009" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, max44009_of_match);
> +
> static const struct i2c_device_id max44009_id[] = {
> { "max44009", 0 },
> { }
> @@ -536,18 +542,13 @@ MODULE_DEVICE_TABLE(i2c, max44009_id);
> static struct i2c_driver max44009_driver = {
> .driver = {
> .name = MAX44009_DRV_NAME,
> + .of_match_table = of_match_ptr(max44009_of_match),
> },
> .probe_new = max44009_probe,
> .id_table = max44009_id,
> };
> module_i2c_driver(max44009_driver);
>
> -static const struct of_device_id max44009_of_match[] = {
> - { .compatible = "maxim,max44009" },
> - { }
> -};
> -MODULE_DEVICE_TABLE(of, max44009_of_match);
> -
> MODULE_AUTHOR("Robert Eshleman <bobbyeshleman@gmail.com>");
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("MAX44009 ambient light sensor driver");
next prev parent reply other threads:[~2023-03-11 12:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:14 [PATCH 1/4] iio: adc: rcar-gyroadc: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 11:14 ` [PATCH 2/4] iio: dac: ad5755: " Krzysztof Kozlowski
2023-03-11 12:22 ` Jonathan Cameron
2023-03-11 12:25 ` Krzysztof Kozlowski
2023-03-11 18:31 ` Jonathan Cameron
2023-03-12 10:11 ` Krzysztof Kozlowski
2023-03-11 11:14 ` [PATCH 3/4] iio: light: max44009: add missing OF device matching Krzysztof Kozlowski
2023-03-11 12:26 ` Jonathan Cameron [this message]
2023-03-11 12:28 ` Krzysztof Kozlowski
2023-03-11 18:35 ` Jonathan Cameron
2023-03-12 10:15 ` Krzysztof Kozlowski
2023-03-11 11:14 ` [PATCH 4/4] iio: proximity: sx9500: Mark ACPI and OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 12:28 ` Jonathan Cameron
2023-03-11 12:30 ` Krzysztof Kozlowski
2023-03-11 18:44 ` Jonathan Cameron
2023-03-12 10:17 ` Krzysztof Kozlowski
2023-03-12 14:14 ` Jonathan Cameron
2023-03-12 15:19 ` Krzysztof Kozlowski
2023-03-11 12:23 ` [PATCH 1/4] iio: adc: rcar-gyroadc: mark " Jonathan Cameron
2023-03-11 12:26 ` Krzysztof Kozlowski
2023-03-11 18:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311122619.2d8bfaf5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=bobbyeshleman@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).