From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
Simon Horman <simon.horman@corigine.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants
Date: Wed, 15 Mar 2023 12:29:05 +0100 [thread overview]
Message-ID: <20230315112905.qutggrdnpsttbase@pengutronix.de> (raw)
In-Reply-To: <20230315104914.qpwhnv6drjwau5jr@blmsp>
[-- Attachment #1: Type: text/plain, Size: 2048 bytes --]
On 15.03.2023 11:49:14, Markus Schneider-Pargmann wrote:
> Hi Krzysztof,
>
> On Tue, Mar 14, 2023 at 09:01:10PM +0100, Krzysztof Kozlowski wrote:
> > On 14/03/2023 16:11, Markus Schneider-Pargmann wrote:
> > > These two new chips do not have state or wake pins.
> > >
> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > > ---
> > > .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++---
> > > 1 file changed, 8 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > > index e3501bfa22e9..38a2b5369b44 100644
> > > --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > > +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > > @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller
> > > This file provides device node information for the TCAN4x5x interface contains.
> > >
> > > Required properties:
> > > - - compatible: "ti,tcan4x5x"
> > > + - compatible:
> > > + "ti,tcan4x5x" or
> > > + "ti,tcan4552" or
> > > + "ti,tcan4553"
> >
> > Awesome, they nicely fit into wildcard... Would be useful to deprecate
> > the wildcard at some point and switch to proper compatibles in such
> > case, because now they became confusing.
> >
> > Anyway:
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Thank you. Indeed the old generic name could be replaced, unfortunately
> I don't have a list of devices that this generic wildcard matches.
The mcp251xfd driver supports "microchip,mcp2517fd",
"microchip,mcp2518fd", "microchip,mcp251863", and "microchip,mcp251xfd".
It always does auto detection and throws a warning if the found chip is
not consistent with the firmware (DT, ACPI).
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-15 11:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:11 [PATCH 0/5] can: tcan4x5x: Introduce tcan4552/4553 Markus Schneider-Pargmann
2023-03-14 15:11 ` [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Markus Schneider-Pargmann
2023-03-14 16:13 ` Simon Horman
2023-03-14 20:01 ` Krzysztof Kozlowski
2023-03-15 10:49 ` Markus Schneider-Pargmann
2023-03-15 11:29 ` Marc Kleine-Budde [this message]
2023-03-15 11:25 ` Marc Kleine-Budde
2023-03-15 13:14 ` Krzysztof Kozlowski
2023-03-15 15:58 ` Markus Schneider-Pargmann
2023-03-15 16:03 ` Simon Horman
2023-03-15 16:07 ` Krzysztof Kozlowski
2023-03-14 15:11 ` [PATCH 2/5] can: tcan4x5x: Remove reserved register 0x814 from writable table Markus Schneider-Pargmann
2023-03-14 15:11 ` [PATCH 3/5] can: tcan4x5x: Check size of mram configuration Markus Schneider-Pargmann
2023-03-14 15:12 ` [PATCH 4/5] can: tcan4x5x: Rename ID registers to match datasheet Markus Schneider-Pargmann
2023-03-14 15:12 ` [PATCH 5/5] can: tcan4x5x: Add support for tcan4552/4553 Markus Schneider-Pargmann
2023-03-14 16:22 ` Simon Horman
2023-03-15 10:41 ` Markus Schneider-Pargmann
2023-03-14 18:19 ` Michal Kubiak
2023-03-14 18:26 ` [PATCH 0/5] can: tcan4x5x: Introduce tcan4552/4553 Michal Kubiak
2023-03-15 10:44 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315112905.qutggrdnpsttbase@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=msp@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).