From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<mawupeng1@huawei.com>, <kuleshovmail@gmail.com>,
<aneesh.kumar@linux.ibm.com>, <david@redhat.com>
Subject: [PATCH v4 3/4] mm/mempolicy: return EINVAL if len overflows for mbind
Date: Mon, 20 Mar 2023 10:47:38 +0800 [thread overview]
Message-ID: <20230320024739.224850-4-mawupeng1@huawei.com> (raw)
In-Reply-To: <20230320024739.224850-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
Return -EINVAL if len overflows for mbind.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/mempolicy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 3a68998adc3a..6b1c45021e48 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1259,6 +1259,7 @@ static long do_mbind(unsigned long start, unsigned long len,
nodemask_t *nmask, unsigned long flags)
{
struct mm_struct *mm = current->mm;
+ unsigned long old_len = len;
struct mempolicy *new;
unsigned long end;
int err;
@@ -1279,7 +1280,7 @@ static long do_mbind(unsigned long start, unsigned long len,
len = PAGE_ALIGN(len);
end = start + len;
- if (end < start)
+ if (end < start || (old_len != 0 && len == 0))
return -EINVAL;
if (end == start)
return 0;
--
2.25.1
next prev parent reply other threads:[~2023-03-20 2:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 2:47 [PATCH v4 0/4] Add overflow checks for several syscalls Wupeng Ma
2023-03-20 2:47 ` [PATCH v4 1/4] mm/mlock: return EINVAL if len overflows for mlock/munlock Wupeng Ma
2023-03-20 10:54 ` David Hildenbrand
2023-03-20 11:05 ` mawupeng
2023-03-21 7:44 ` mawupeng
2023-03-21 14:19 ` David Hildenbrand
2023-03-22 2:14 ` mawupeng
2023-03-22 8:54 ` David Hildenbrand
2023-03-22 9:01 ` David Hildenbrand
2023-03-22 9:20 ` mawupeng
2023-03-22 11:27 ` David Hildenbrand
2023-03-20 2:47 ` [PATCH v4 2/4] mm/mempolicy: return EINVAL for if len overflows for set_mempolicy_home_node Wupeng Ma
2023-03-20 2:47 ` Wupeng Ma [this message]
2023-03-20 2:47 ` [PATCH v4 4/4] mm/msync: return ENOMEM if len overflows for msync Wupeng Ma
2023-03-20 11:06 ` [PATCH v4 0/4] Add overflow checks for several syscalls mawupeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320024739.224850-4-mawupeng1@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).