From: Jim Cromie <jim.cromie@gmail.com>
To: mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 0/4] cosmetic fixes to module pr_debugs
Date: Tue, 21 Mar 2023 19:36:19 -0600 [thread overview]
Message-ID: <20230322013623.251401-1-jim.cromie@gmail.com> (raw)
Hi Luis,
These 4 patches alter pr_debug() messages for more info, and less
log-spam.
* add "for $modname:" to banners
helpful for finding one of many
[ 40.885922] main:layout_sections: Core section allocation order for test_dynamic_debug:
~20 lines of output
[ 40.885967] main:move_module: Final section addresses for test_dynamic_debug:
~2 lines - .init.text/data
* add symbol name to "Absolute symbol: <value>"
val ~== 0 - less interesting than name
[ 40.886006] main:simplify_symbols: Absolute symbol: 0x00000000 test_dynamic_debug.c
[ 40.886008] main:simplify_symbols: Absolute symbol: 0x00000000 test_dynamic_debug.mod.c
* add size to section report. gives more info.
[ 40.885968] main:move_module: 0xffffffffc0249000 0x0000035d .text
[ 40.885971] main:move_module: 0xffffffffc0252000 0x0000003c .init.text
* drop already_uses: pr_debug("$ uses $b!") messages
echo module main +pmf >/proc/dynamic_debug/control
modprobe i915
before:
dmesg | grep already_uses | cut -c15- | wc
673 2722 28641
dmesg | grep already_uses | cut -c15- | sort -u | wc
26 134 1237
after:
dmesg | grep already_uses | cut -c15- | wc
15 90 756
dmesg | grep already_uses | cut -c15- | sort -u | wc
15 90 756
Jim Cromie (4):
module: in layout_sections, move_module: add the modname
module: add symbol-name to pr_debug Absolute symbol
module: add section-size to move_module pr_debug
module: already_uses() - reduce pr_debug output volume
kernel/module/main.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
--
2.39.2
next reply other threads:[~2023-03-22 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 1:36 Jim Cromie [this message]
2023-03-22 1:36 ` [PATCH 1/4] module: in layout_sections, move_module: add the modname Jim Cromie
2023-03-22 1:36 ` [PATCH 2/4] module: add symbol-name to pr_debug Absolute symbol Jim Cromie
2023-03-22 1:36 ` [PATCH 3/4] module: add section-size to move_module pr_debug Jim Cromie
2023-03-22 1:36 ` [PATCH 4/4] module: already_uses() - reduce pr_debug output volume Jim Cromie
2023-03-22 23:38 ` [PATCH 0/4] cosmetic fixes to module pr_debugs Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322013623.251401-1-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).