From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D32F3C77B60
	for <linux-kernel@archiver.kernel.org>; Thu, 23 Mar 2023 16:43:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232412AbjCWQn1 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 23 Mar 2023 12:43:27 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39540 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231636AbjCWQnC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Mar 2023 12:43:02 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF3977EE1;
        Thu, 23 Mar 2023 09:40:40 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id E4580B821C8;
        Thu, 23 Mar 2023 16:40:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A4FFC433EF;
        Thu, 23 Mar 2023 16:40:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1679589635;
        bh=C6zbcam0xUhqGIfoAQN43u6ixgPQPCK5MXt51f5tQ+g=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=pRfB86HvPG+N1+COI+X5YsHdDxWA2NjhUDXInRcRJDCMba2LlCyhLjVaF0jVk/zkD
         yjbWGIIxAM/Lv1tdKJFynZe8SHo5Q4x9uaQPvgAoSaag4h+CDmOmlf2cs9NYIovc9v
         j+12A01A1Aeg/bIx2UfQF7K6Rygyl2FVqWaI/xLnut4vsO1ZPEi6940r0Ndb9H1Ulp
         g0uHfKKw06LEgY66EB3oERVvEPjRKk6MVV7XWPTOvJoEpePJfzAHOOvMPC/dkpSuln
         6D7vLgrquuoqrbwMBXzD7KO+hMl2XTRJILL1DimurM04P+5LWyzTO5NYHoz/S278hs
         AMUzVxrBl6lsg==
Date:   Thu, 23 Mar 2023 09:40:34 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running()
Message-ID: <20230323094034.5b021c65@kernel.org>
In-Reply-To: <CAMuHMdUt_kTH3tnrdF=oKBLyjrstei8PLsyr+dFXVoPEyxTLAA@mail.gmail.com>
References: <20230321065826.2044-1-wsa+renesas@sang-engineering.com>
        <79d945a4-e105-4bc4-3e73-64971731660e@omp.ru>
        <CAMuHMdUt_kTH3tnrdF=oKBLyjrstei8PLsyr+dFXVoPEyxTLAA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 23 Mar 2023 09:32:27 +0100 Geert Uytterhoeven wrote:
> Is there some protection against parallel execution of ndo_open()
> and get_stats()?

Nope - one is under rtnl_lock, the other under just RCU, IIRC.
So this patch just makes the race worse, but it was already
racy before.