From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
Paul Elder <paul.elder@ideasonboard.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] media: rkisp1: Make local immutable array variables static const
Date: Fri, 24 Mar 2023 11:37:44 +0100 [thread overview]
Message-ID: <20230324103744.ww67j3di73xg4ois@uno.localdomain> (raw)
In-Reply-To: <Y9MMhSVrWujmfgCR@pendragon.ideasonboard.com>
Hello
the change seems trivial, do we need an explicit ack from Dafna ?
Dafna are you comfortable being listed as maintainer of this driver or
do you think you won't be able to dedicate time to it and need help ?
Thanks
j
On Fri, Jan 27, 2023 at 01:28:05AM +0200, Laurent Pinchart wrote:
> Hi Dafna,
>
> On Sun, Nov 20, 2022 at 12:28:01AM +0200, Laurent Pinchart wrote:
> > Hi Dafna,
> >
> > Are you fine with this patch, can I include it in my next pull request
> > along with the other ones from the series ?
>
> Ping.
>
> > On Thu, Nov 17, 2022 at 05:42:16PM +0900, Paul Elder wrote:
> > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > The max_widths and max_heights variables in rkisp1_try_fmt() are
> > > immutable and don't need to be allocated on the stack every time the
> > > function is called. Make them static.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> > > ---
> > > .../media/platform/rockchip/rkisp1/rkisp1-capture.c | 12 ++++++++----
> > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> > > index 7695ef134908..91e685fdbbe9 100644
> > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> > > @@ -1150,13 +1150,17 @@ static void rkisp1_try_fmt(const struct rkisp1_capture *cap,
> > > const struct rkisp1_capture_fmt_cfg **fmt_cfg,
> > > const struct v4l2_format_info **fmt_info)
> > > {
> > > + static const unsigned int max_widths[] = {
> > > + RKISP1_RSZ_MP_SRC_MAX_WIDTH,
> > > + RKISP1_RSZ_SP_SRC_MAX_WIDTH,
> > > + };
> > > + static const unsigned int max_heights[] = {
> > > + RKISP1_RSZ_MP_SRC_MAX_HEIGHT,
> > > + RKISP1_RSZ_SP_SRC_MAX_HEIGHT,
> > > + };
> > > const struct rkisp1_capture_config *config = cap->config;
> > > const struct rkisp1_capture_fmt_cfg *fmt;
> > > const struct v4l2_format_info *info;
> > > - const unsigned int max_widths[] = { RKISP1_RSZ_MP_SRC_MAX_WIDTH,
> > > - RKISP1_RSZ_SP_SRC_MAX_WIDTH };
> > > - const unsigned int max_heights[] = { RKISP1_RSZ_MP_SRC_MAX_HEIGHT,
> > > - RKISP1_RSZ_SP_SRC_MAX_HEIGHT};
> > >
> > > fmt = rkisp1_find_fmt_cfg(cap, pixm->pixelformat);
> > > if (!fmt) {
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2023-03-24 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 8:42 [PATCH v2 0/3] media: rkisp1: Miscellaneous improvements Paul Elder
2022-11-17 8:42 ` [PATCH v2 1/3] media: rkisp1: Add NV16M and NV61M to output formats Paul Elder
2022-11-19 10:59 ` Dafna Hirschfeld
2022-11-17 8:42 ` [PATCH v2 2/3] media: rkisp1: Make local immutable array variables static const Paul Elder
2022-11-19 22:28 ` Laurent Pinchart
2023-01-26 23:28 ` Laurent Pinchart
2023-03-24 10:37 ` Jacopo Mondi [this message]
2023-03-25 19:24 ` Laurent Pinchart
2022-11-17 8:42 ` [PATCH v2 3/3] media: rkisp1: Implement ENUM_FRAMESIZES Paul Elder
2022-11-19 10:57 ` Dafna Hirschfeld
2023-02-21 13:57 ` [PATCH v2 0/3] media: rkisp1: Miscellaneous improvements Jacopo Mondi
2023-03-25 20:00 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324103744.ww67j3di73xg4ois@uno.localdomain \
--to=jacopo.mondi@ideasonboard.com \
--cc=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).