From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B19C74A5B for ; Wed, 29 Mar 2023 19:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230287AbjC2T6J (ORCPT ); Wed, 29 Mar 2023 15:58:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjC2T6G (ORCPT ); Wed, 29 Mar 2023 15:58:06 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 206361BD8 for ; Wed, 29 Mar 2023 12:58:06 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E1EBC3200902; Wed, 29 Mar 2023 15:58:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 29 Mar 2023 15:58:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1680119884; x=1680206284; bh=2U pu4KS/HglgZqR5QPgAuFmmlBS7eNJtiUFPyeWRlVg=; b=ji4rtCkiOQkBU+MsPc TZUZ27CAkQZLcaYtr4LvaerHn0KLrfz7wsUxjDfb06+6AUEcmCai/nmbD849mds6 pAyXoiBRd0Y0oHnAuL5j35CnwuuTf1KWDR9KtLgsiL+US8VKk8PZlC3w028BvYee fw/luSJ3pPsxM80NwyQPF/Y1E8aa0WGQRxS/GnoLtjWssvxZH6lV39nD9jL4H3Dc QhaXiSq5CwoRd5/uRjl/S/x78e/OKbLdRPcoKljYa0Yu1bBTNu3VTR6uWGO06zvq /CU1/fqNelBCrC0+ZysF316g3fe2RfhRb9NX0zncglvh/dree6R/86/9W12jJICU qAaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680119884; x=1680206284; bh=2Upu4KS/HglgZ qR5QPgAuFmmlBS7eNJtiUFPyeWRlVg=; b=SrDiGXfwY6CSrYJm1C4SYYpl4AR0e ZlN+XAsubo35P8rS2DUAkRhc8yh7hRuXYfg+x2F35AjBrhE5UJgPiiRMmeLh7rQZ oLryKLu+yN5kDNVLTZd0FFWjocCi88QB9HBT2GM5OSQvYbKL+j3EzIL8ndh1a9RZ RCTNRfczpXW8+GPLrpa/J4vWxHGUl9LmGxmG0iH2oTYj7GRdhVmDV96cA4D2xcur Zte73guvCKL0ieYsH1BTuKydJO35kW+X2Oe+KTW4dqTbFsKc5DNABD1+7Je7r8Xk QjfEi6zOXYPQgNjUOSxfvL9MbYHm066MaeaouIbPtRxqH6h6ojO4G2NaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehiedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepgfduhedttdegudffuefgvefhveejtdevgeegteejudeuueefvdfgkedv uddvhfffnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgv tghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Mar 2023 15:58:03 -0400 (EDT) Date: Wed, 29 Mar 2023 21:58:02 +0200 From: Maxime Ripard To: Roman Beranek Cc: Frank Oltmanns , Chen-Yu Tsai , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG Message-ID: <20230329195802.veybo3367zifw77n@penduick> References: <20230320161636.24411-1-romanberanek@icloud.com> <87wn356ni4.fsf@oltmanns.dev> <20230327202045.ceeqqwjug4ktxtsf@penduick> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jhubbfpnry7jtl6t" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jhubbfpnry7jtl6t Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 28, 2023 at 01:48:33AM +0200, Roman Beranek wrote: > On Mon Mar 27, 2023 at 10:20 PM CEST, Maxime Ripard wrote: > > > > On Sat, Mar 25, 2023 at 12:40:04PM +0100, Frank Oltmanns wrote: > > > Claiming to set the divider to a different value (bpp / lanes) than w= hat we=E2=80=99re actually using in > > > the end (SUN6I_DSIO_TCON_DIV) is somehow bugging me. I feel like the = proposal that I submitted is > > > more direct: > > > > Yeah, this patch looks better to me too: it's simpler, more straightfor= ward. If Roman can confirm it > > works with his testing, I'll be happy to merge it. > > >=20 > So I've just found out that my understanding of what sun4i_dotclock is > was wrong the whole time. I treated it as a virtual clock representing > the true CRTC pixel clock and only coincidentally also matching what > A64 Reference Manual labels as TCON0 data clock (a coincidence to which > DSI is an exception). >=20 > Now that I finally see dotclock as 'what could dclk be an abbreviation > to', I to agree that it's not only straightforward but also correct to > keep the divider at 4 and adjust the rate as is done it the patch Frank > submitted. >=20 > In order to preserve semantic correctness however, I propose to preface > the change with a patch that renames sun4i_dotclock and tcon-pixel-clock > such that dot/pixel is replaced with d/data. What do you think? I don't think it's exposed to the userspace in any way so it makes sense to= me Maxime --jhubbfpnry7jtl6t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZCSYSgAKCRDj7w1vZxhR xQgyAP4iRhVGZNaSGJ5BGI2H6CXWA1Oi2JNtRr4PQZ4IkSWWIwD/Zqs+v+sDPinR jz7XAk8q+wY/CSPp0d7d34Th7Zj6qgQ= =KqnG -----END PGP SIGNATURE----- --jhubbfpnry7jtl6t--