From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2871EC6FD1D for ; Thu, 30 Mar 2023 14:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232249AbjC3OFG (ORCPT ); Thu, 30 Mar 2023 10:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232081AbjC3OE6 (ORCPT ); Thu, 30 Mar 2023 10:04:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 517FD7ED3 for ; Thu, 30 Mar 2023 07:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680185050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tTBdaSwbBU7yvMf5yJjwPQAmSwIig1jMctqroIy2Uf0=; b=cnFFvQVkp98do7iie8CpIs6S/nQglUuF/kOBZoqpai/qNvxiG2XgtyhBRNCfoQDMjZPYxp NzDGDpSxGZh1z26m6Zvlo4bPqfLcZSowUeUw5ufyw+YQSvFptgyZuWVdkr42FCWNJGGFQC 0sRSV6lT9cjGCQHUsh93bHYX9JDrFFk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-VXshoszeOq26ku0gDVrI2g-1; Thu, 30 Mar 2023 10:04:08 -0400 X-MC-Unique: VXshoszeOq26ku0gDVrI2g-1 Received: by mail-wr1-f69.google.com with SMTP id h18-20020adfa4d2000000b002cea098a651so2013614wrb.3 for ; Thu, 30 Mar 2023 07:04:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680185047; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tTBdaSwbBU7yvMf5yJjwPQAmSwIig1jMctqroIy2Uf0=; b=S1zSSHnTA9zUhH4ZSrzhKK8iUaVZPjiBYEu7X2lJAboAf8IwyqRiFDy9/wpGsaMhQK sE5zYyPpA+ZyBCLDsmCXkI0TGVgmlKNyfRwNsjo/0kHgaJlZIUhIbSlMfAJ4YPsHwR/S McUd+LbwQi8lADi4VKtxYwNw7TYupl0V4KewX7xQTq6M0y2VMDMKr38nm2wiaR28BAQD SdYrSFT92eJFL4GdPXny9LILX115+K7S7oo6cF6EYxgvQycvQ79nAjzIfKK69Z5vsGMg 3woQasFORj/Q/zRtzUFa397zDE4AtMjQGuBVLJOj8NrGljK/j5sgE+HyG/FpM0UR1SLU y/vA== X-Gm-Message-State: AAQBX9dZZNy0jm3hzi8dZLcHPGW7iqpmrBVe32iAv6gcVnuF+9Hu4TFf CCM7AEdxUgOCurwXiI7Ltj9jaFrQ+n0JqtuuypMkPadxP+EDAKRmaxItQvMQ5LHIism2X9izVbd +0XMOH/WvKL9BaxN+ybFWBU2o X-Received: by 2002:adf:fd47:0:b0:2dc:cad4:87b9 with SMTP id h7-20020adffd47000000b002dccad487b9mr20764971wrs.68.1680185047554; Thu, 30 Mar 2023 07:04:07 -0700 (PDT) X-Google-Smtp-Source: AKy350baz3ZKnOOUo2PwHSQ/hKwGrXzV97e3RmZVOT6SkIIWFbJS2PWUhgbo4anxuinm8NAuAgc/Ow== X-Received: by 2002:adf:fd47:0:b0:2dc:cad4:87b9 with SMTP id h7-20020adffd47000000b002dccad487b9mr20764942wrs.68.1680185047192; Thu, 30 Mar 2023 07:04:07 -0700 (PDT) Received: from redhat.com ([2.52.159.107]) by smtp.gmail.com with ESMTPSA id e9-20020adffc49000000b002be5bdbe40csm32969834wrs.27.2023.03.30.07.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 07:04:06 -0700 (PDT) Date: Thu, 30 Mar 2023 10:04:03 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: Willem de Bruijn , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Jakub Kicinski , Wei Wang , David Miller , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] virtio: fix up virtio_disable_cb Message-ID: <20230330100219-mutt-send-email-mst@kernel.org> References: <20210526082423.47837-1-mst@redhat.com> <20210526082423.47837-4-mst@redhat.com> <1680156457.5551112-5-xuanzhuo@linux.alibaba.com> <20230330024220-mutt-send-email-mst@kernel.org> <1680159261.1588428-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1680159261.1588428-1-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 02:54:21PM +0800, Xuan Zhuo wrote: > On Thu, 30 Mar 2023 02:44:44 -0400, "Michael S. Tsirkin" wrote: > > On Thu, Mar 30, 2023 at 02:07:37PM +0800, Xuan Zhuo wrote: > > > On Wed, 26 May 2021 04:24:40 -0400, "Michael S. Tsirkin" wrote: > > > > virtio_disable_cb is currently a nop for split ring with event index. > > > > This is because it used to be always called from a callback when we know > > > > device won't trigger more events until we update the index. However, > > > > now that we run with interrupts enabled a lot we also poll without a > > > > callback so that is different: disabling callbacks will help reduce the > > > > number of spurious interrupts. > > > > Further, if using event index with a packed ring, and if being called > > > > from a callback, we actually do disable interrupts which is unnecessary. > > > > > > > > Fix both issues by tracking whenever we get a callback. If that is > > > > the case disabling interrupts with event index can be a nop. > > > > If not the case disable interrupts. Note: with a split ring > > > > there's no explicit "no interrupts" value. For now we write > > > > a fixed value so our chance of triggering an interupt > > > > is 1/ring size. It's probably better to write something > > > > related to the last used index there to reduce the chance > > > > even further. For now I'm keeping it simple. > > > > > > > > > Don't understand, is this patch necessary? For this patch set, we can do without > > > this patch. > > > > > > So doest this patch optimize virtqueue_disable_cb() by reducing a modification of > > > vring_used_event(&vq-> split.vring)? > > > > > > Or I miss something. > > > > > > Thanks. > > > > Before this patch virtqueue_disable_cb did nothing at all > > for the common case of event index enabled, so > > calling it from virtio net would not help matters. > > I agree with these codes: > > - if (!vq->event) > + if (vq->event) > + /* TODO: this is a hack. Figure out a cleaner value to write. */ > + vring_used_event(&vq->split.vring) = 0x0; > + else > > > I just don't understand event_triggered. The comment near it says it all: /* Hint for event idx: already triggered no need to disable. */ the write into event idx is potentially expensive since it can invalidate cache for another processor (depending on the CPU). > > > > But the patch is from 2021, isn't it a bit too late to argue? > > If you have a cleanup or an optimization in mind, please > > post a patch. > > Sorry, I just have some problems, I don't oppose it. At least it can reduce the > modification of vring_used_event(&vq->split.vring). I think it is also beneficial. > > Thanks very much. > > > > > > > > > > > > Signed-off-by: Michael S. Tsirkin > > > > --- > > > > drivers/virtio/virtio_ring.c | 26 +++++++++++++++++++++++++- > > > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > > > index 71e16b53e9c1..88f0b16b11b8 100644 > > > > --- a/drivers/virtio/virtio_ring.c > > > > +++ b/drivers/virtio/virtio_ring.c > > > > @@ -113,6 +113,9 @@ struct vring_virtqueue { > > > > /* Last used index we've seen. */ > > > > u16 last_used_idx; > > > > > > > > + /* Hint for event idx: already triggered no need to disable. */ > > > > + bool event_triggered; > > > > + > > > > union { > > > > /* Available for split ring */ > > > > struct { > > > > @@ -739,7 +742,10 @@ static void virtqueue_disable_cb_split(struct virtqueue *_vq) > > > > > > > > if (!(vq->split.avail_flags_shadow & VRING_AVAIL_F_NO_INTERRUPT)) { > > > > vq->split.avail_flags_shadow |= VRING_AVAIL_F_NO_INTERRUPT; > > > > - if (!vq->event) > > > > + if (vq->event) > > > > + /* TODO: this is a hack. Figure out a cleaner value to write. */ > > > > + vring_used_event(&vq->split.vring) = 0x0; > > > > + else > > > > vq->split.vring.avail->flags = > > > > cpu_to_virtio16(_vq->vdev, > > > > vq->split.avail_flags_shadow); > > > > @@ -1605,6 +1611,7 @@ static struct virtqueue *vring_create_virtqueue_packed( > > > > vq->weak_barriers = weak_barriers; > > > > vq->broken = false; > > > > vq->last_used_idx = 0; > > > > + vq->event_triggered = false; > > > > vq->num_added = 0; > > > > vq->packed_ring = true; > > > > vq->use_dma_api = vring_use_dma_api(vdev); > > > > @@ -1919,6 +1926,12 @@ void virtqueue_disable_cb(struct virtqueue *_vq) > > > > { > > > > struct vring_virtqueue *vq = to_vvq(_vq); > > > > > > > > + /* If device triggered an event already it won't trigger one again: > > > > + * no need to disable. > > > > + */ > > > > + if (vq->event_triggered) > > > > + return; > > > > + > > > > if (vq->packed_ring) > > > > virtqueue_disable_cb_packed(_vq); > > > > else > > > > @@ -1942,6 +1955,9 @@ unsigned virtqueue_enable_cb_prepare(struct virtqueue *_vq) > > > > { > > > > struct vring_virtqueue *vq = to_vvq(_vq); > > > > > > > > + if (vq->event_triggered) > > > > + vq->event_triggered = false; > > > > + > > > > return vq->packed_ring ? virtqueue_enable_cb_prepare_packed(_vq) : > > > > virtqueue_enable_cb_prepare_split(_vq); > > > > } > > > > @@ -2005,6 +2021,9 @@ bool virtqueue_enable_cb_delayed(struct virtqueue *_vq) > > > > { > > > > struct vring_virtqueue *vq = to_vvq(_vq); > > > > > > > > + if (vq->event_triggered) > > > > + vq->event_triggered = false; > > > > + > > > > return vq->packed_ring ? virtqueue_enable_cb_delayed_packed(_vq) : > > > > virtqueue_enable_cb_delayed_split(_vq); > > > > } > > > > @@ -2044,6 +2063,10 @@ irqreturn_t vring_interrupt(int irq, void *_vq) > > > > if (unlikely(vq->broken)) > > > > return IRQ_HANDLED; > > > > > > > > + /* Just a hint for performance: so it's ok that this can be racy! */ > > > > + if (vq->event) > > > > + vq->event_triggered = true; > > > > + > > > > pr_debug("virtqueue callback for %p (%p)\n", vq, vq->vq.callback); > > > > if (vq->vq.callback) > > > > vq->vq.callback(&vq->vq); > > > > @@ -2083,6 +2106,7 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index, > > > > vq->weak_barriers = weak_barriers; > > > > vq->broken = false; > > > > vq->last_used_idx = 0; > > > > + vq->event_triggered = false; > > > > vq->num_added = 0; > > > > vq->use_dma_api = vring_use_dma_api(vdev); > > > > #ifdef DEBUG > > > > -- > > > > MST > > > > > > > > _______________________________________________ > > > > Virtualization mailing list > > > > Virtualization@lists.linux-foundation.org > > > > https://lists.linuxfoundation.org/mailman/listinfo/virtualization > >