From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A368CC77B62 for ; Sun, 2 Apr 2023 15:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbjDBPoe (ORCPT ); Sun, 2 Apr 2023 11:44:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230283AbjDBPoc (ORCPT ); Sun, 2 Apr 2023 11:44:32 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBE33592; Sun, 2 Apr 2023 08:44:31 -0700 (PDT) Received: from zn.tnic (p5de8e687.dip0.t-ipconnect.de [93.232.230.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4DE171EC0464; Sun, 2 Apr 2023 17:44:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1680450269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=vQcaoKs/WxKbULaS5V6K0JDkCQY6Irgs3SFQbr71L4Q=; b=iVMRLK+q6loLxDv3MSGsW2KkKCZ8v16oUEr8Gwh6NALthDikMK68MLvhysoI2hOq6BXseI HsN35LZHkIa0xhz8KAFNx0dEYYg/uTFtYYRSQPm8Zq6KuwiTqmpwPw9w2SLNRmCO+38ti/ /q+/6JoOhm9IChvyQ5i/BZkLtRRiVMI= Date: Sun, 2 Apr 2023 17:44:25 +0200 From: Borislav Petkov To: Jeremi Piotrowski Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Brijesh Singh , Tom Lendacky , "Kalra, Ashish" , linux-crypto@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, Ingo Molnar , Dave Hansen , x86@kernel.org Subject: Re: [PATCH v3 0/8] Support ACPI PSP on Hyper-V Message-ID: <20230402154425.GCZCmi2eiKYO2yYhNs@fat_crate.local> References: <20230320191956.1354602-1-jpiotrowski@linux.microsoft.com> <20230322154655.GDZBsi75f6LnQStxSp@fat_crate.local> <1d25221c-eaab-0f97-83aa-8b4fbe3a53ed@linux.microsoft.com> <20230322181541.GEZBtFzRAMcH9BAzUe@fat_crate.local> <20230323152342.GFZBxu/m3u6aFUDY/7@fat_crate.local> <105d019c-2249-5dfd-e032-95944ea6dc8c@linux.microsoft.com> <20230323163450.GGZBx/qpnclFnMaf7e@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 06:10:09PM +0100, Jeremi Piotrowski wrote: > Since the AMD PSP is a privileged device, there is a desire to not have to trust the > ACPI stack, And yet you do: + err = acpi_parse_aspt(&res[0], &pdata); + if (err) + return err; You don't trust the ACPI stack, and yet you're parsing an ACPI table?!?! You have to make up your mind here. Btw, you still haven't answered my question about doing: devm_request_irq(dev, 9, ..) where 9 is the default ACPI interrupt. You can have some silly table tell you what to map or you can simply map IRQ 9 and be done with it. In this second case you can *really* not trust ACPI because you know which IRQ it is. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette