From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A1BC6FD1D for ; Tue, 4 Apr 2023 12:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234667AbjDDM0q (ORCPT ); Tue, 4 Apr 2023 08:26:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234677AbjDDM0m (ORCPT ); Tue, 4 Apr 2023 08:26:42 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB9E1BEF; Tue, 4 Apr 2023 05:26:19 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D541B240003; Tue, 4 Apr 2023 12:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680611178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NlIRywC4pBj6a77Ol7zVTt0l3l1RJQnARY7smlHQSoI=; b=b3SYEGCikmzsZum+IK+K9om+oODTu3b9DYJuS+Uc8KGZ4imW5U/8DqBYvFOGFDewJiGKsf kQ7CxLM9WoqkOXOm+eL6RzzlIkKw39Xknz9aysx5xuCoA7k7wBS1UZMPzXYrL2ogBtw8vq ZmxB/o3t8el2Wmp17Nx4cI6i4NrqywrjVa7l7gH7pjluXLkoIYUieOsHRvSKtNjeFTz7DO wVuvNFDzgKbK4O4XzCMJ8r7HSa9by7vHD0D8DhkUYodYqDUzsPjd+UwxcehnSLi8GoPFsR JwHoGLgXFlxTnVSLtcg3//Zdmmi8THPgO6x5xosFJeWGuUOF709V3DBz8Yh5pA== Date: Tue, 4 Apr 2023 14:26:16 +0200 From: Alexandre Belloni To: "Tilki, Ibrahim" Cc: Krzysztof Kozlowski , "a.zummo@towertech.it" , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "Arslanbenzer, Zeynep" Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Message-ID: <202304041226162e231e78@mail.local> References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com> <20230403154342.3108-3-Ibrahim.Tilki@analog.com> <202304040710049c9cc01a@mail.local> <1efdb870-cac2-f6ed-72b5-d0550dbb5257@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2023 10:35:53+0000, Tilki, Ibrahim wrote: > >>>>> + aux-voltage-chargeable: > >>>>> + enum: [0, 1, 2] > >>>>> + description: | > >>>>> + Enables trickle charger. > >>>>> + 0: Charger is disabled (default) > >>>>> + 1: Charger is enabled > >>>>> + 2: Charger is enabled with a diode > >>>> > >>>> 2 is not an allowed value. I asked to drop this property. It is coming > >>>> from rtc.yaml. I also do not understand "with a diode". So otherwise it > >>>> is charging with, I don't know, FET? > >>> > >>> No, what is not explained here (and maybe not unsterstood by the > >>> submitter) is that the RTC has an extra diode so, charging will always > >>> enable a diode, select a resistor and then have or not an extra diode. > >>> Figure2 of the MAX31329 datasheet is great. > >>> > >> > >> That is exactly why I had "adi,trickle-diode-enable" property in previous patch. > >> So if I can't have "adi,trickle-diode-enable" and can't add an additional value > >> to "aux-voltage-chargeable", I am not sure how to add support for the extra > >> diode at this point. > > > > Ask the person who asked you to remove adi,trickle-diode-enable... > > That was the purpose. > If the earlier submission was clearer my answer would have been different but note how I had to dig up the datasheet to understand there were two diodes. All the trickle chargers have a schottky diode so "adi,trickle-diode-enable" nor the commit log were explicit about the second diode (which is a regular diode). aux-voltage-chargeable is enabling a diode on all the existing RTC drivers so instead of trying to make me look like the bad guy you should rather thank for taking the time trying to get better DT bindings. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com