From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEEDC77B62 for ; Tue, 4 Apr 2023 12:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234760AbjDDM3e (ORCPT ); Tue, 4 Apr 2023 08:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234878AbjDDM31 (ORCPT ); Tue, 4 Apr 2023 08:29:27 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D38A610A; Tue, 4 Apr 2023 05:29:14 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EFBDA100003; Tue, 4 Apr 2023 12:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680611353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1s8oWqXZyH3J7vnCQRYvzoMuk5JY0jzBHnJpra4pFT4=; b=LEkYgQFJZRrGQY7HJb36jYtHL0Cs9mApMZhHebK3mUTfeinteLbMlDsHL3KSPbOlVgZoku EAe3a+QvGcBW1OSutA/vaI8wainzIOjfXEfdNBaFgDaOluu0PpQ7dtQzNWMq96pmCLyTye 3DWfvAQXLIvvvtTauUovUmg5iNQ1k5eOgcWz6aGlSRe38adX2n3ZzRTqTIFsG+m4FqaNMv 5oX7D8X+DELGEAknSKMXGaIx9c9yNGzWHHLhHLWv5Rx8t1Zp5ilrFQkacnLaJi6xfDgMw7 UwVfaaAD9O56Sm2YSGKC7UKAT1is7oeV6jxFOLi49o+UBx5L3MQhHfbJFu/w6g== Date: Tue, 4 Apr 2023 14:29:11 +0200 From: Alexandre Belloni To: "Tilki, Ibrahim" Cc: Krzysztof Kozlowski , "a.zummo@towertech.it" , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "Arslanbenzer, Zeynep" Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Message-ID: <2023040412291166c04438@mail.local> References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com> <20230403154342.3108-3-Ibrahim.Tilki@analog.com> <202304040710049c9cc01a@mail.local> <1efdb870-cac2-f6ed-72b5-d0550dbb5257@linaro.org> <202304041226162e231e78@mail.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202304041226162e231e78@mail.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2023 14:26:18+0200, Alexandre Belloni wrote: > On 04/04/2023 10:35:53+0000, Tilki, Ibrahim wrote: > > >>>>> + aux-voltage-chargeable: > > >>>>> + enum: [0, 1, 2] > > >>>>> + description: | > > >>>>> + Enables trickle charger. > > >>>>> + 0: Charger is disabled (default) > > >>>>> + 1: Charger is enabled > > >>>>> + 2: Charger is enabled with a diode > > >>>> > > >>>> 2 is not an allowed value. I asked to drop this property. It is coming > > >>>> from rtc.yaml. I also do not understand "with a diode". So otherwise it > > >>>> is charging with, I don't know, FET? > > >>> > > >>> No, what is not explained here (and maybe not unsterstood by the > > >>> submitter) is that the RTC has an extra diode so, charging will always > > >>> enable a diode, select a resistor and then have or not an extra diode. > > >>> Figure2 of the MAX31329 datasheet is great. > > >>> > > >> > > >> That is exactly why I had "adi,trickle-diode-enable" property in previous patch. > > >> So if I can't have "adi,trickle-diode-enable" and can't add an additional value > > >> to "aux-voltage-chargeable", I am not sure how to add support for the extra > > >> diode at this point. > > > > > > Ask the person who asked you to remove adi,trickle-diode-enable... > > > > That was the purpose. > > > > If the earlier submission was clearer my answer would have been > different but note how I had to dig up the datasheet to understand there > were two diodes. All the trickle chargers have a schottky diode so > "adi,trickle-diode-enable" nor the commit log were explicit about the > second diode (which is a regular diode). > > aux-voltage-chargeable is enabling a diode on all the existing RTC > drivers so instead of trying to make me look like the bad guy you should > rather thank for taking the time trying to get better DT bindings. > BTW, Krzysztof, you should focus more on how v5 of the driver is still abusing the #clock-cells property to do pinmuxing after I repeatedly explain to not do that. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com