From: Eric Biggers <ebiggers@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v5 3/6] soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver
Date: Thu, 6 Apr 2023 13:34:32 -0700 [thread overview]
Message-ID: <20230406203432.GC20288@sol.localdomain> (raw)
In-Reply-To: <20230403200530.2103099-4-abel.vesa@linaro.org>
On Mon, Apr 03, 2023 at 11:05:27PM +0300, Abel Vesa wrote:
> This takes the already existing duplicated support in both ufs-qcom
> and sdhci-msm drivers and makes it a dedicated driver that can be used
> by both mentioned drivers. The reason for this is because, staring with
> SM8550, the ICE IP block is shared between UFS and SDCC, which means we
> need to probe a dedicated device and share it between those two
> consumers. So let's add the ICE dedicated driver as a soc driver.
> Platforms that already have ICE supported, will use it as a library
> as the of_qcom_ice_get will return an ICE instance created for the
> consumer device. This allows the backwards compatibility with old-style
> devicetree approach. Also, add support to HW version 4.x since it
> works out-of-the-box with the current driver. The 4.x HW version is
> found on SM8550 platform.
Can you please split up long paragraphs like this into multiple paragraphs?
> + pdev = of_find_device_by_node(node);
> + if (!pdev) {
> + dev_err(dev, "Cannot find device node %s\n", node->name);
> + ice = ERR_PTR(-EPROBE_DEFER);
> + goto out;
> + }
> +
> + ice = platform_get_drvdata(pdev);
> + if (!ice) {
> + dev_err(dev, "Cannot get ice instance from %s\n",
> + dev_name(&pdev->dev));
> + platform_device_put(pdev);
> + ice = ERR_PTR(-EPROBE_DEFER);
> + goto out;
> + }
> +
> + ice->link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER);
> + if (!ice->link) {
> + dev_err(&pdev->dev,
> + "Failed to create device link to consumer %s\n",
> + dev_name(dev));
> + ice = ERR_PTR(-EINVAL);
> + }
Is a call to platform_device_put() missing above?
- Eric
next prev parent reply other threads:[~2023-04-06 20:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:05 [PATCH v5 0/6] Add dedicated Qcom ICE driver Abel Vesa
2023-04-03 20:05 ` [PATCH v5 1/6] dt-bindings: crypto: Add Qualcomm Inline Crypto Engine Abel Vesa
2023-04-03 20:05 ` [PATCH v5 2/6] dt-bindings: ufs: qcom: Add ICE phandle Abel Vesa
2023-04-04 5:41 ` Krzysztof Kozlowski
2023-04-04 8:59 ` Abel Vesa
2023-04-04 10:12 ` Krzysztof Kozlowski
2023-04-04 10:41 ` Abel Vesa
2023-04-04 11:03 ` Krzysztof Kozlowski
2023-04-03 20:05 ` [PATCH v5 3/6] soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver Abel Vesa
2023-04-06 20:34 ` Eric Biggers [this message]
2023-04-03 20:05 ` [PATCH v5 4/6] scsi: ufs: ufs-qcom: Switch to the new ICE API Abel Vesa
2023-04-06 20:16 ` Eric Biggers
2023-04-07 7:02 ` Abel Vesa
2023-04-07 17:28 ` Eric Biggers
2023-04-03 20:05 ` [PATCH v5 5/6] mmc: sdhci-msm: " Abel Vesa
2023-04-06 20:22 ` Eric Biggers
2023-04-03 20:05 ` [PATCH v5 6/6] arm64: dts: qcom: sm8550: Add the Inline Crypto Engine node Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406203432.GC20288@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).