linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyril Brulebois <cyril@debamax.com>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Michal Suchanek <msuchanek@suse.de>,
	linux-kernel@vger.kernel.org, Cyril Brulebois <cyril@debamax.com>,
	stable@vger.kernel.org
Subject: [PATCH 1/2] fbdev/offb: Update expected device name
Date: Wed, 12 Apr 2023 11:55:08 +0200	[thread overview]
Message-ID: <20230412095509.2196162-2-cyril@debamax.com> (raw)
In-Reply-To: <20230412095509.2196162-1-cyril@debamax.com>

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many
"of-display.N" as required.

This means that offb no longer finds the expected device, which prevents
the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the
hardcoded device from "of-display" to "of-display.0" is confirmed to fix
the Debian Installer at the very least.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
Link: https://bugs.debian.org/1033058
Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
Cc: stable@vger.kernel.org
Signed-off-by: Cyril Brulebois <cyril@debamax.com>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index b97d251d894b..6264c7184457 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
 
 static struct platform_driver offb_driver_display = {
 	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
 		.of_match_table = offb_of_match_display,
 	},
 	.probe = offb_probe_display,
-- 
2.30.2


  reply	other threads:[~2023-04-12  9:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  9:55 Updating hardcoded "of-display" devices Cyril Brulebois
2023-04-12  9:55 ` Cyril Brulebois [this message]
2023-04-16 12:34   ` [PATCH 1/2] fbdev/offb: Update expected device name Salvatore Bonaccorso
2023-06-15 13:03     ` Linux regression tracking (Thorsten Leemhuis)
2023-06-15 13:06       ` Thomas Zimmermann
2023-06-15 13:21         ` Michal Suchánek
2023-06-15 20:09           ` Rob Herring
2023-06-15 21:19             ` Cyril Brulebois
2023-06-20  6:24               ` Helge Deller
2023-06-20  8:04                 ` Michal Suchánek
2023-06-15 13:12       ` Cyril Brulebois
2023-04-22  9:50   ` Helge Deller
2023-04-24  7:31   ` Geert Uytterhoeven
2023-07-10 16:36   ` Michal Suchánek
2023-04-12  9:55 ` [PATCH 2/2] drm/ofdrm: " Cyril Brulebois
2023-04-24  7:33   ` Geert Uytterhoeven
2023-04-24  9:07     ` Thomas Zimmermann
2023-04-24  9:35       ` Helge Deller
2023-05-22  9:37         ` Linux regression tracking (Thorsten Leemhuis)
2023-05-22 11:44       ` Michal Suchánek
2023-07-10 16:36   ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230412095509.2196162-2-cyril@debamax.com \
    --to=cyril@debamax.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msuchanek@suse.de \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).