From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEBFC77B75 for ; Tue, 18 Apr 2023 22:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232372AbjDRWCJ (ORCPT ); Tue, 18 Apr 2023 18:02:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231872AbjDRWCE (ORCPT ); Tue, 18 Apr 2023 18:02:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBA3A5FC for ; Tue, 18 Apr 2023 15:02:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C095A6399E for ; Tue, 18 Apr 2023 22:02:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C64CCC433EF; Tue, 18 Apr 2023 22:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681855322; bh=JNP1xB5GIvgJJmSbKQabnxhJhbq3MlZMoGbPthN+Vlw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dU3s35zGaGQzcQIfZFASfRNiGP2LdPGekM1pWmXlWZWgaUS9hn+0/k1HvMtL7uR1X kyh2TcXFLCX/PC+aWFRFmbDBTtbsC9VkH2l5BRRhbn5dPTAsrgzmlRn9Tjc9n+EMBk 0BDCNKFs9eKooI+KQaHxVeapVFr8SM6tVJLQrX5E= Date: Tue, 18 Apr 2023 15:02:00 -0700 From: Andrew Morton To: Marcelo Tosatti Cc: Christoph Lameter , Aaron Tomlin , Frederic Weisbecker , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org, Vlastimil Babka , Michal Hocko Subject: Re: [PATCH v7 00/13] fold per-CPU vmstats remotely Message-Id: <20230418150200.027528c155853fea8e4f58b2@linux-foundation.org> In-Reply-To: <20230320180332.102837832@redhat.com> References: <20230320180332.102837832@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Mar 2023 15:03:32 -0300 Marcelo Tosatti wrote: > This patch series addresses the following two problems: > > 1. A customer provided evidence indicating that a process > was stalled in direct reclaim: > > ... > > 2. With a task that busy loops on a given CPU, > the kworker interruption to execute vmstat_update > is undesired and may exceed latency thresholds > for certain applications. > I don't think I'll be sending this upstream in the next merge window. Because it isn't clear that the added complexity in vmstat handling is justified. - Michal's request for more clarity on the end-user requirements seems reasonable. - You have indicated that additional changelog material is forthcoming. - The alternative idea of adding a syscall which tells the kernel "I'm about to go realtime, so please clear away all the pending crap which might later interrupt me" sounds pretty good. Partly because there are surely other places where we can use this. Partly because it moves all the crap-clearing into special crap-clearing code paths while adding less burden to the commonly-executed code. And I don't think this alternative has been fully investigated and discussed.