From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: peterhuewe@gmx.de, jarkko@kernel.org
Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, l.sanfilippo@kunbus.com,
peter.ujfalusi@linux.intel.com, jsnitsel@redhat.com,
pmenzel@molgen.mpg.de
Subject: [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only
Date: Wed, 24 May 2023 11:58:44 +0300 [thread overview]
Message-ID: <20230524085844.11580-1-peter.ujfalusi@linux.intel.com> (raw)
The original patch which added the quirk would apply to all AAEON machines,
which might or might not be valid.
The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the
i12 (Alder Lake) version is affected.
UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing
and confirmed by dmidecode).
Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.
Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
Suggested-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
Hi Jarkko,
Changes since v1:
- Findings from Paul Menzel in the commit message has been addressed
the patch is generated on top of your
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm
Regards,
Peter
drivers/char/tpm/tpm_tis.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 7db3593941ea..4357d4ba8f9e 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
.ident = "UPX-TGL",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
},
},
{}
--
2.40.1
next reply other threads:[~2023-05-24 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 8:58 Peter Ujfalusi [this message]
2023-06-09 18:44 ` [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524085844.11580-1-peter.ujfalusi@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).