From: Conor Dooley <conor.dooley@microchip.com>
To: Atish Patra <atishp@atishpatra.org>
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>,
Anup Patel <anup@brainfault.org>,
Song Shuai <suagrfillet@gmail.com>, <robh@kernel.org>,
Andrew Jones <ajones@ventanamicro.com>, <palmer@rivosinc.com>,
<jeeheng.sia@starfivetech.com>, <leyfoon.tan@starfivetech.com>,
<mason.huo@starfivetech.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Guo Ren <guoren@kernel.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <regressions@lists.linux.dev>
Subject: Re: Bug report: kernel paniced when system hibernates
Date: Thu, 25 May 2023 13:55:37 +0100 [thread overview]
Message-ID: <20230525-geologist-cottage-a51fa889a3d0@wendy> (raw)
In-Reply-To: <CAOnJCUJQdZZ3kT099Z6gcj+A4fP7ste3dC9QZ8G-2XH7x8DL7A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Wed, May 24, 2023 at 04:53:59PM -0700, Atish Patra wrote:
> We can also just revert the commit
> 3335068 ("riscv: Use PUD/P4D/PGD pages for the linear mapping")
> until a proper solution is available.
I'm actually inclined to go the other day. If hibernation never works
in a released kernel we can't regress it & since we have not settled on
a fix for this yet we don't know whether the fix would then remove
support for hibernation where it used to work.
> IIRC, Alex also suggested the same as there is no measured benefit
> with this patch.
> It is good to have 1GB huge page mappings but it can be delayed until
> we have the fix
> for the hibernation issue.
IIRC it was the 1 GiB hugepages that Alex said were ~worthless.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-25 12:56 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 9:24 Bug report: kernel paniced when system hibernates Song Shuai
2023-05-16 9:55 ` JeeHeng Sia
2023-05-16 11:14 ` Alexandre Ghiti
2023-05-16 11:27 ` JeeHeng Sia
2023-05-17 8:33 ` Alexandre Ghiti
2023-05-18 4:06 ` JeeHeng Sia
2023-05-16 11:12 ` Alexandre Ghiti
2023-05-17 8:58 ` Alexandre Ghiti
2023-05-17 11:05 ` Song Shuai
[not found] ` <CAHVXubgjgMvFV0MOABbtKr+2TH85+0kow7wOrjxFCP5iXt1saQ@mail.gmail.com>
2023-05-17 14:42 ` Fwd: " Alexandre Ghiti
2023-05-18 1:29 ` JeeHeng Sia
2023-05-18 9:13 ` Alexandre Ghiti
2023-05-18 3:29 ` Song Shuai
2023-05-18 11:54 ` Alexandre Ghiti
2023-05-17 11:27 ` Conor Dooley
2023-05-17 14:55 ` Alexandre Ghiti
2023-05-18 6:53 ` Anup Patel
2023-05-18 7:59 ` Conor Dooley
2023-05-18 8:41 ` Alexandre Ghiti
2023-05-18 10:35 ` Conor Dooley
2023-05-18 11:58 ` Alexandre Ghiti
2023-05-24 23:53 ` Atish Patra
2023-05-25 12:55 ` Conor Dooley [this message]
2023-05-18 12:21 ` JeeHeng Sia
2023-05-18 12:09 ` Alexandre Ghiti
2023-05-18 14:04 ` Anup Patel
2023-05-24 13:49 ` Conor Dooley
2023-05-24 13:57 ` Alexandre Ghiti
2023-05-24 15:59 ` Conor Dooley
2023-05-24 23:45 ` Atish Patra
2023-05-25 13:08 ` Conor Dooley
2023-05-25 13:21 ` Anup Patel
2023-05-25 13:37 ` Conor Dooley
2023-05-25 13:43 ` Anup Patel
2023-05-25 13:55 ` Conor Dooley
2023-05-25 13:59 ` Anup Patel
2023-05-25 14:20 ` Conor Dooley
2023-05-25 17:39 ` Atish Patra
2023-05-25 18:22 ` Conor Dooley
2023-05-25 18:37 ` Atish Patra
2023-05-25 18:39 ` Conor Dooley
2023-05-25 20:06 ` Atish Patra
2023-05-25 21:24 ` Conor Dooley
2023-05-26 13:14 ` Alexandre Ghiti
2023-05-26 14:59 ` Conor Dooley
2023-05-26 15:12 ` Alexandre Ghiti
2023-05-26 15:17 ` Anup Patel
2023-05-26 15:22 ` Alexandre Ghiti
2023-05-26 18:48 ` Atish Patra
2023-05-16 11:35 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525-geologist-cottage-a51fa889a3d0@wendy \
--to=conor.dooley@microchip.com \
--cc=ajones@ventanamicro.com \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=guoren@kernel.org \
--cc=jeeheng.sia@starfivetech.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mason.huo@starfivetech.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=regressions@lists.linux.dev \
--cc=robh@kernel.org \
--cc=suagrfillet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).