linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	David Sterba <dsterba@suse.com>, Christoph Lameter <cl@linux.com>,
	David Rientjes <rientjes@google.com>,
	Pekka Enberg <penberg@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH] mm/slab: add new flag SLAB_NO_MERGE to avoid merging per slab
Date: Thu, 25 May 2023 14:05:25 +0200	[thread overview]
Message-ID: <20230525120524.GH30909@suse.cz> (raw)
In-Reply-To: <70763661-b2a2-4bf2-f589-e0d71083f1bd@suse.cz>

On Wed, May 24, 2023 at 03:53:11PM +0200, Vlastimil Babka wrote:
> On 5/24/23 14:56, Hyeonggon Yoo wrote:
> > On Wed, May 24, 2023 at 12:17:48PM +0200, David Sterba wrote:
> > work for your use case? (there are some boot-time slub_debug options described in
> > Documentation/mm/slub.rst)
> 
> Yeah, it supports globbing so it would be e.g. slub_debug=N,btrfs*
> That would deal with the "too coarse" aspect slab_nomerge. As for "need to
> be enabled on all testing hosts", is it more convenient to deploy a debug
> kernel build on them? Might be because you do that for other reasons
> already? Just want to clarify.

Yeah, agreed.

> BTW this was proposed as RFC few months ago but not pursued:
> https://lore.kernel.org/all/167396280045.539803.7540459812377220500.stgit@firesoul/
> 
> I have no big objections, just wouldn't like to see its usage proliferate
> unconditionally into non-debug builds.

It would be fine for me to make it conditionally available, e.g.
depending on SLUB_DEBUG.

  reply	other threads:[~2023-05-25 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 10:17 [PATCH] mm/slab: add new flag SLAB_NO_MERGE to avoid merging per slab David Sterba
2023-05-24 12:56 ` Hyeonggon Yoo
2023-05-24 13:53   ` Vlastimil Babka
2023-05-25 12:05     ` David Sterba [this message]
2023-05-25 11:59   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525120524.GH30909@suse.cz \
    --to=dsterba@suse.cz \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=dsterba@suse.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).