From: Shawn Guo <shawnguo@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
linux-arm-kernel@lists.infradead.org,
Alistair Francis <alistair@alistair23.me>,
Fabio Estevam <festevam@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Mark Brown <broonie@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Russell King <linux@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Stefan Hansson <newbie13xd@gmail.com>,
Stefan Wahren <stefan.wahren@chargebyte.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config
Date: Sat, 27 May 2023 20:44:28 +0800 [thread overview]
Message-ID: <20230527124428.GT528183@dragon> (raw)
In-Reply-To: <b8166ed7-2d3b-4bdd-b597-f0aeddb7ecdc@app.fastmail.com>
On Wed, May 24, 2023 at 08:48:26AM +0200, Arnd Bergmann wrote:
> On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote:
> > The KERNEL_GZIP is used in most config and is the default, there is no
> > clear reason to diverge so let default be used.
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> I don't mind that change, but it seems odd to single this one out, as
> there are many other options in that particular defconfig that
> stick out more, picking LZO seems like a reasonable choice for slightly
> faster booting, though ZSTD would be the more modern choice.
>
> If you are looking into cleaning up this file, maybe see if we can
> kill off these options:
>
> CONFIG_EXPERT=y
> CONFIG_ARCH_FORCE_MAX_ORDER=13
> CONFIG_CMDLINE="noinitrd console=ttymxc0,115200"
> CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files
> CONFIG_SMC91X=y
> CONFIG_SMC911X=y
> CONFIG_SMSC911X=y
> CONFIG_STAGING=y
> CONFIG_STAGING_MEDIA=y
> CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years
> CONFIG_EXT2_FS=y
> CONFIG_EXT3_FS=y # select EXT4 instead
> CONFIG_ISO9660_FS=m
>
> I have not investigated why any of them were added originally,
> so it's likely that some are actually needed.
Otavio,
Would you investigate the suggested options and see if we can clean up
more than just KERNEL_LZO?
Shawn
next prev parent reply other threads:[~2023-05-27 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 21:28 [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config Otavio Salvador
2023-05-23 21:54 ` Fabio Estevam
2023-05-24 6:48 ` Arnd Bergmann
2023-05-24 10:47 ` Francesco Dolcini
2023-05-27 12:44 ` Shawn Guo [this message]
2023-05-27 13:29 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230527124428.GT528183@dragon \
--to=shawnguo@kernel.org \
--cc=alistair@alistair23.me \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=mpe@ellerman.id.au \
--cc=newbie13xd@gmail.com \
--cc=otavio@ossystems.com.br \
--cc=s.hauer@pengutronix.de \
--cc=stefan.wahren@chargebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).