From: Kees Cook <keescook@chromium.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Regressions <regressions@lists.linux.dev>,
Linux Memory Management List <linux-mm@kvack.org>,
Jeff Xu <jeffxu@google.com>,
Daniel Verkamp <dverkamp@chromium.org>,
David Herrmann <dh.herrmann@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hugh Dickins <hughd@google.com>, Jann Horn <jannh@google.com>,
Jorge Lucangeli Obes <jorgelo@chromium.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Stuart Foster <smf-linux@virginmedia.com>
Subject: Re: Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL"
Date: Thu, 1 Jun 2023 07:12:06 -0700 [thread overview]
Message-ID: <202306010710.7F5C39B7A@keescook> (raw)
In-Reply-To: <38f847ed-69dc-d5da-5822-bd9da753fc30@suse.cz>
On Thu, Jun 01, 2023 at 09:18:47AM +0200, Vlastimil Babka wrote:
> On 6/1/23 04:07, Bagas Sanjaya wrote:
> > Hi,
> >
> > I notice a regression report on Bugzilla [1]. Quoting from it:
> >
> >> Recent kernels seem to generate this:
> >>
> >> "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=3976 'Xorg'"
> >>
> >> Is this a kernel problem or something to do with Xorg ?
> >>
> >> Seen in Kernels 6.3.4 and 6.4.0-rc4.
> >>
> >> Thanks
> >
> > See Bugzilla for the full thread and attached logs (dmesg, xorg, bisection
> > log).
> >
> > Anyway, I'm adding it to regzbot:
> >
> > #regzbot introduced: 105ff5339f498a https://bugzilla.kernel.org/show_bug.cgi?id=217508
> > #regzbot title: memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL on Xorg
>
> Hm indeed it seems to have introduced 2 new flags and immediately warn if
> any process doesn't use them. Maybe it would make sense for some of the
> non-default values of vm.memfd_noexec, but it's too early to warn
> unconditionally everywhere, no?
This is pretty standard for getting new options like this noticed by
userspace -- there is no regression in _behavior_. It's just a reminder
to fix userspace code.
-Kees
> >
> > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217508
> >
>
--
Kees Cook
next prev parent reply other threads:[~2023-06-01 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 2:07 Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL" Bagas Sanjaya
2023-06-01 7:18 ` Vlastimil Babka
2023-06-01 14:12 ` Kees Cook [this message]
2023-06-02 2:15 ` Bagas Sanjaya
2023-06-02 7:12 ` Stuart Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306010710.7F5C39B7A@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dverkamp@chromium.org \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jeffxu@google.com \
--cc=jorgelo@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=regressions@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=smf-linux@virginmedia.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).