From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 983ACC77B7E for ; Thu, 1 Jun 2023 06:23:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231476AbjFAGXT (ORCPT ); Thu, 1 Jun 2023 02:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbjFAGXQ (ORCPT ); Thu, 1 Jun 2023 02:23:16 -0400 Received: from forward500a.mail.yandex.net (forward500a.mail.yandex.net [IPv6:2a02:6b8:c0e:500:1:45:d181:d500]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E76569D for ; Wed, 31 May 2023 23:23:14 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-64.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-64.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0f:170e:0:640:d60c:0]) by forward500a.mail.yandex.net (Yandex) with ESMTP id 835A65EAB3; Thu, 1 Jun 2023 09:23:12 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-64.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 8NHZtKnDcKo0-x2OmZw4k; Thu, 01 Jun 2023 09:23:11 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1685600591; bh=ki6bsIOUWk6t8+U9O/0o/525tnGGk/hTfP3gdeX9qC0=; h=Cc:Message-ID:Subject:Date:References:To:From:In-Reply-To; b=mZMh0UflxiVGZj/n7PFjR1B+hqk7U8o1yWy/BWo2kb8rHJeE8VrUkDcp0L3UDBGbF PLxnct1c0hBrSn6VLsAYGyl+/KYJsXR5fKyueNFO7EwyvkGR7qaDAvS0ZQoUrgp21b XNUvN1NRYwXgxnTIovf2jnGstW9qvoosifwKIqFA= Authentication-Results: mail-nwsmtp-smtp-production-main-64.vla.yp-c.yandex.net; dkim=pass header.i=@maquefel.me Date: Thu, 1 Jun 2023 09:23:08 +0300 From: Nikita Shubin To: Paul Menzel Cc: Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Joel Stanley , Conor Dooley , Heiko Stuebner , Yinbo Zhu , Hitomi Hasegawa , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Walker Chen , Emil Renner Berthing , Alexander Gordeev , Vasily Gorbik , Michael Peters , Kris Bahnsen , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 03/43] soc: Add SoC driver for Cirrus ep93xx Message-ID: <20230601092215.26d4c88f@redslave.neermore.group> In-Reply-To: References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601053546.9574-4-nikita.shubin@maquefel.me> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Paul. Thnak you for your comments. On Thu, 1 Jun 2023 07:53:38 +0200 Paul Menzel wrote: > Dear Nikita, >=20 >=20 > Thank you for your patch. Some small nit picks. >=20 > Am 01.06.23 um 07:33 schrieb Nikita Shubin: > > This adds an SoC driver for the ep93xx. Currently there > > is only one thing not fitting into any other framework, > > and that is the swlock setting. =20 >=20 > If you reflow for 75 characters per line, this would fit into two > lines. >=20 > > It's used for clock settings and restart. =20 >=20 > What datasheet did you use, and on what board did you test this? Adding link to v0 series: https://lore.kernel.org/all/20230424123522.18302-1-nikita.shubin@maquefel.m= e/ Tested on ts7250 64 RAM/128 MiB Nand flash, edb9302. > What datasheet did you use ep9301/ep9302/ep9307/ep9312/ep9315 datasheet ep93xx user guide >=20 > > Signed-off-by: Nikita Shubin > > Tested-by: Alexander Sverdlin > > Acked-by: Alexander Sverdlin > > Reviewed-by: Linus Walleij > > --- =20 >=20 > [=E2=80=A6] >=20 > > drivers/soc/Kconfig | 1 + > > drivers/soc/Makefile | 1 + > > drivers/soc/cirrus/Kconfig | 11 +++ > > drivers/soc/cirrus/Makefile | 2 + > > drivers/soc/cirrus/soc-ep93xx.c | 134 > > ++++++++++++++++++++++++++++++ include/linux/soc/cirrus/ep93xx.h | > > 16 +++- 6 files changed, 161 insertions(+), 4 deletions(-) > > create mode 100644 drivers/soc/cirrus/Kconfig > > create mode 100644 drivers/soc/cirrus/Makefile > > create mode 100644 drivers/soc/cirrus/soc-ep93xx.c > >=20 > > diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig > > index 4e176280113a..6149f0447b61 100644 > > --- a/drivers/soc/Kconfig > > +++ b/drivers/soc/Kconfig > > @@ -30,5 +30,6 @@ source "drivers/soc/ti/Kconfig" > > source "drivers/soc/ux500/Kconfig" > > source "drivers/soc/versatile/Kconfig" > > source "drivers/soc/xilinx/Kconfig" > > +source "drivers/soc/cirrus/Kconfig" > > =20 > > endmenu > > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > > index 3b0f9fb3b5c8..7a8a154b8d96 100644 > > --- a/drivers/soc/Makefile > > +++ b/drivers/soc/Makefile > > @@ -36,3 +36,4 @@ obj-y +=3D ti/ > > obj-$(CONFIG_ARCH_U8500) +=3D ux500/ > > obj-$(CONFIG_PLAT_VERSATILE) +=3D versatile/ > > obj-y +=3D xilinx/ > > +obj-$(CONFIG_EP93XX_SOC) +=3D cirrus/ > > diff --git a/drivers/soc/cirrus/Kconfig b/drivers/soc/cirrus/Kconfig > > new file mode 100644 > > index 000000000000..bc82c0422325 > > --- /dev/null > > +++ b/drivers/soc/cirrus/Kconfig > > @@ -0,0 +1,11 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +if ARCH_EP93XX > > + > > +config EP93XX_SOC > > + bool "Cirrus EP93xx chips SoC" > > + default y if !EP93XX_SOC_COMMON > > + help > > + Support Soc for Cirrus EP93xx chips. =20 >=20 > Above (and more common in the whole SOC directory) you spell it SoC. >=20 > > + > > +endif > > diff --git a/drivers/soc/cirrus/Makefile > > b/drivers/soc/cirrus/Makefile new file mode 100644 > > index 000000000000..ed6752844c6f > > --- /dev/null > > +++ b/drivers/soc/cirrus/Makefile > > @@ -0,0 +1,2 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +obj-y +=3D soc-ep93xx.o > > diff --git a/drivers/soc/cirrus/soc-ep93xx.c > > b/drivers/soc/cirrus/soc-ep93xx.c new file mode 100644 > > index 000000000000..64842e9e2316 > > --- /dev/null > > +++ b/drivers/soc/cirrus/soc-ep93xx.c > > @@ -0,0 +1,134 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Soc driver for Cirrus EP93xx chips. =20 >=20 > Ditto. >=20 > > + * Copyright (C) 2022 Nikita Shubin > > + * > > + * Based on a rewrite of arch/arm/mach-ep93xx/core.c > > + * Copyright (C) 2006 Lennert Buytenhek > > + * Copyright (C) 2007 Herbert Valerio Riedel > > + * > > + * Thanks go to Michael Burian and Ray Lehtiniemi for their key > > + * role in the ep93xx linux community =20 >=20 > If you know their email addresses, you could add those too. Maybe > also add a dot/period at the end. >=20 > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define EP93XX_SYSCON_DEVCFG 0x80 > > + > > +#define EP93XX_SWLOCK_MAGICK 0xaa > > +#define EP93XX_SYSCON_SWLOCK 0xc0 > > +#define EP93XX_SYSCON_SYSCFG 0x9c > > +#define EP93XX_SYSCON_SYSCFG_REV_MASK (0xf0000000) > > +#define EP93XX_SYSCON_SYSCFG_REV_SHIFT (28) =20 >=20 > [=E2=80=A6] >=20 >=20 > Kind regards, >=20 > Paul