From: Herve Codina <herve.codina@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices
Date: Mon, 5 Jun 2023 19:22:45 +0200 [thread overview]
Message-ID: <20230605192245.4132e0ae@bootlin.com> (raw)
In-Reply-To: <20230528183855.0c95d308@jic23-huawei>
Hi Jonathan,
On Sun, 28 May 2023 18:38:55 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 23 May 2023 17:12:21 +0200
> Herve Codina <herve.codina@bootlin.com> wrote:
>
> > Industrial I/O devices can be present in the audio path.
> > These devices needs to be used as audio components in order to be fully
> > integrated in the audio path.
> >
> > This support allows to consider these Industrial I/O devices as auxliary
> > audio devices and allows to control them using mixer controls.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > ---
>
> > diff --git a/sound/soc/codecs/audio-iio-aux.c b/sound/soc/codecs/audio-iio-aux.c
> > new file mode 100644
> > index 000000000000..21575c4b35fd
> > --- /dev/null
> > +++ b/sound/soc/codecs/audio-iio-aux.c
> > @@ -0,0 +1,302 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +//
> > +// audio-iio-aux.c -- ALSA SoC glue to use IIO devices as audio components
> > +//
> > +// Copyright 2023 CS GROUP France
> > +//
> > +// Author: Herve Codina <herve.codina@bootlin.com>
> > +
> > +#include <linux/iio/consumer.h>
> > +#include <linux/module.h>
>
> #include <linux/mod_devicetable.h> ideally to pick up
> the of_device_id definition without bouncing through some non
> obvious header path.
Right, <linux/module.h> will be replaced by <linux/mod_devicetable.h> in the
next iteration.
Thanks for the review,
Hervé
>
>
> > +#include <linux/slab.h>
> > +#include <sound/soc.h>
> > +#include <sound/tlv.h>
>
> Otherwise, the IIO elements of this look good. So for those at least
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> I don't have enough knowledge of the snd stuff to review those
> parts.
>
> Jonathan
>
>
next prev parent reply other threads:[~2023-06-05 17:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:12 [PATCH v2 0/9] Add support for IIO devices in ASoC Herve Codina
2023-05-23 15:12 ` [PATCH v2 1/9] ASoC: dt-bindings: Add audio-iio-aux Herve Codina
2023-05-23 15:12 ` [PATCH v2 2/9] ASoC: dt-bindings: simple-card: Add additional-devs subnode Herve Codina
2023-05-23 15:12 ` [PATCH v2 3/9] iio: inkern: Check error explicitly in iio_channel_read_max() Herve Codina
2023-05-28 17:32 ` Jonathan Cameron
2023-05-23 15:12 ` [PATCH v2 4/9] iio: consumer.h: Fix raw values documentation notes Herve Codina
2023-05-28 17:29 ` Jonathan Cameron
2023-05-23 15:12 ` [PATCH v2 5/9] iio: inkern: Add a helper to query an available minimum raw value Herve Codina
2023-05-28 17:33 ` Jonathan Cameron
2023-06-03 14:04 ` andy.shevchenko
2023-06-05 7:46 ` Herve Codina
2023-06-05 9:45 ` Andy Shevchenko
2023-06-05 14:11 ` Herve Codina
2023-06-05 17:05 ` Jonathan Cameron
2023-06-05 17:36 ` Herve Codina
2023-05-23 15:12 ` [PATCH v2 6/9] ASoC: soc-dapm.h: Add a helper to build a DAPM widget dynamically Herve Codina
2023-06-03 14:07 ` andy.shevchenko
2023-06-05 8:54 ` Herve Codina
2023-06-05 12:35 ` Herve Codina
2023-05-23 15:12 ` [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices Herve Codina
2023-05-28 17:38 ` Jonathan Cameron
2023-06-05 17:22 ` Herve Codina [this message]
2023-06-03 18:26 ` andy.shevchenko
2023-06-06 13:54 ` Herve Codina
2023-06-06 14:34 ` Andy Shevchenko
2023-06-07 14:56 ` Herve Codina
2023-06-07 13:23 ` Herve Codina
2023-05-23 15:12 ` [PATCH v2 8/9] ASoC: simple-card: Add missing of_node_put() in case of error Herve Codina
2023-05-23 23:24 ` Kuninori Morimoto
2023-05-23 15:12 ` [PATCH v2 9/9] ASoC: simple-card: Handle additional devices Herve Codina
2023-05-24 0:08 ` Kuninori Morimoto
2023-05-24 0:36 ` Kuninori Morimoto
2023-05-24 12:14 ` Herve Codina
2023-05-25 0:01 ` Kuninori Morimoto
2023-05-26 13:07 ` Herve Codina
2023-05-29 0:18 ` Kuninori Morimoto
2023-06-03 18:27 ` andy.shevchenko
2023-05-26 16:31 ` (subset) [PATCH v2 0/9] Add support for IIO devices in ASoC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605192245.4132e0ae@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).