From: Rob Herring <robh@kernel.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
kernel@pengutronix.de,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property
Date: Wed, 7 Jun 2023 16:58:48 -0600 [thread overview]
Message-ID: <20230607225848.GA131389-robh@kernel.org> (raw)
In-Reply-To: <69fdb6a2-12b6-547d-019b-c77dd2bd98cf@tronnes.org>
On Wed, Jun 07, 2023 at 09:59:47PM +0200, Noralf Trønnes wrote:
>
>
> On 6/7/23 13:55, Leonard Göhrs wrote:
> > Some MIPI DBI panels support a three wire mode (clock, chip select,
> > bidirectional data) that can be used to ask the panel if it is already set
> > up by e.g. the bootloader and can thus skip the initialization.
> > This enables a flicker-free boot.
> >
> > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> > ---
> > .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> > index c07da1a9e6288..2f0238b770eba 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> > @@ -87,6 +87,8 @@ properties:
> > Logic level supply for interface signals (Vddi).
> > No need to set if this is the same as power-supply.
> >
> > + spi-3wire: true
> > +
>
> I don't think this should be added here. spi-cpha and spi-cpol are also
> supported but they are not mentioned. Instead those are documented in
> bindings/spi/spi-controller.yaml. Why they're not documented in
> bindings/spi/spi-peripheral-props.yaml instead which this binding has a
> ref to, I have no idea.
spi-peripheral-props.yaml are properties of the controller in the
peripheral nodes. spi-cpha and spi-cpol are properties of the device
which are completely invalid on some devices. We can only check that by
documenting where they are valid. I think spi-3wire is similar. There
should be more explanation in the spi-peripheral-props.yaml commit
history.
Rob
next prev parent reply other threads:[~2023-06-07 22:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 11:55 [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible Leonard Göhrs
2023-06-07 11:55 ` [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property Leonard Göhrs
2023-06-07 17:54 ` Conor Dooley
2023-06-07 19:59 ` Noralf Trønnes
2023-06-07 22:58 ` Rob Herring [this message]
2023-06-07 22:59 ` Rob Herring
2023-06-07 11:55 ` [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property Leonard Göhrs
2023-06-07 16:36 ` andy.shevchenko
2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-13 14:54 ` Bartosz Golaszewski
2023-06-07 11:55 ` [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties Leonard Göhrs
2023-06-07 17:51 ` Conor Dooley
2023-06-07 23:03 ` Rob Herring
2023-06-07 11:55 ` [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties Leonard Göhrs
2023-06-07 17:50 ` Conor Dooley
2023-06-07 23:04 ` Rob Herring
2023-06-07 11:55 ` [PATCH v1 6/8] ARM: dts: stm32: Add pinmux groups for Linux Automation GmbH TAC Leonard Göhrs
2023-06-08 13:02 ` Alexandre TORGUE
2023-06-07 11:55 ` [PATCH v1 7/8] dt-bindings: arm: stm32: Add compatible string for Linux Automation LXA TAC Leonard Göhrs
2023-06-07 17:29 ` Conor Dooley
2023-06-07 11:55 ` [PATCH v1 8/8] ARM: dts: stm32: lxa-tac: add Linux Automation GmbH TAC Leonard Göhrs
2023-06-08 13:13 ` Alexandre TORGUE
2023-06-14 12:46 ` Leonard Göhrs
2023-06-07 17:55 ` [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible Conor Dooley
2023-06-07 22:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607225848.GA131389-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).