From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE54C7EE25 for ; Thu, 8 Jun 2023 17:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236515AbjFHROh (ORCPT ); Thu, 8 Jun 2023 13:14:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbjFHROe (ORCPT ); Thu, 8 Jun 2023 13:14:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62DEE59 for ; Thu, 8 Jun 2023 10:14:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7030964F81 for ; Thu, 8 Jun 2023 17:14:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35C1AC433D2; Thu, 8 Jun 2023 17:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686244472; bh=R1L6b3wgbiK874cLJ3MogGauggBNR+aYC0k6slCiep0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lwuELfVCtQW00XSO3oJ3XcVCV5ox+/2z8vUhaiNl81TKhQuZE+PMEORvkviZ4n4mS gC6Lhy3XyugFnER6NKGbV1FNAEkopXMWFHawmR9+W1t/kdHsvttMWCh4HgskqrKD5m J5dkpV8DY70/GNEgVRtRsYUyU6znpXEGpqblJTsT2XN3VDRxryQwO1W6Vb78vkNGix ovGkh77TUHpgliwWHhd7tJuAVs+XXXuEbPkoWeQso6xv08lz2e1xx+dCpr0wwc+z9q Pj4Xu5/NOXcR/1Ae2OjhZODxEanNyrMXv2rN+InBkTkIY2IsCRBeltq/QGZrQ3ScI4 vrI0Jd94teIlQ== Date: Thu, 8 Jun 2023 18:14:29 +0100 From: Lee Jones To: Jiasheng Jiang Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: intel-lpss: Add missing check for platform_get_resource Message-ID: <20230608171429.GF3572061@google.com> References: <20230531100257.17769-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230531100257.17769-1-jiasheng@iscas.ac.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2023, Jiasheng Jiang wrote: > Add the missing check for platform_get_resource and return error > if it fails. > > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices") > Signed-off-by: Jiasheng Jiang > --- > drivers/mfd/intel-lpss-acpi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c > index a143c8dca2d9..1a6ebd3d9795 100644 > --- a/drivers/mfd/intel-lpss-acpi.c > +++ b/drivers/mfd/intel-lpss-acpi.c > @@ -183,6 +183,9 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev) > return -ENOMEM; > > info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!info->mem) > + return -ENOMEM; This does not mean we're out of memory. Please use either -EINVAL or -ENODEV. > + > info->irq = platform_get_irq(pdev, 0); > > ret = intel_lpss_probe(&pdev->dev, info); > -- > 2.25.1 > -- Lee Jones [李琼斯]