From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78571C7EE25 for ; Thu, 8 Jun 2023 17:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbjFHRai (ORCPT ); Thu, 8 Jun 2023 13:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbjFHRae (ORCPT ); Thu, 8 Jun 2023 13:30:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1C2F95; Thu, 8 Jun 2023 10:30:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55E5464FCA; Thu, 8 Jun 2023 17:30:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0026AC433D2; Thu, 8 Jun 2023 17:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686245432; bh=jzImsaW9M4mP3N4OMbgFXFtC9VulvLbRUrXD1c3RT+4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2YRSciH18KnS2omzxp1D0TOnR+9JCWqvvbW2FCOlFjoyan3V9hLi+Z4TxM1dBiuQ DwLEfJMCqrl/NpRYiDnE/2HBZpvP62MFTUARvI6Nk8qKNv/nFsM4fEwyAm+bnaZlS3 QNhaaPmavriI9sa1Db88XF3RRsDpKbmyRIUEf/4FNXj8xFcxJbGR7JMxHkoBJTc7A9 KNYoLa0qdi5KNkAUopPHwJ2S0hAGTq4xAawLosDdT55/99ddxinCNo0IFcUwHza67Q Ze2RZIZOtdCCb0Iyp/XPd6OtVG0KIEPcuXoPtOWvYhTBEQH/DG1z6CZzK1CD8ihIp1 v1kBSi+KVDwcw== Date: Thu, 8 Jun 2023 18:30:27 +0100 From: Lee Jones To: Andy Shevchenko Cc: Henning Schild , Pavel Machek , Hans de Goede , Mark Gross , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables Message-ID: <20230608173027.GL3572061@google.com> References: <20230524124628.32295-1-henning.schild@siemens.com> <20230524124628.32295-2-henning.schild@siemens.com> <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Jun 2023, Andy Shevchenko wrote: > On Tue, May 30, 2023 at 05:11:00PM +0200, Henning Schild wrote: > > Am Sat, 27 May 2023 11:54:08 +0300 > > schrieb Andy Shevchenko : > > > > > On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote: > > > > The entries do not seem to be stricly needed when the number of > > > > entries is given via the number of LEDs. But adding them is a > > > > safeguard should anyone ever iterate over the tables to their end, > > > > it also gets us in line with other drivers that register > > > > "leds-gpio" tables. > > > > > > Reported-by? > > > Reviewed-by: Andy Shevchenko > > > > I think we could do > > > > Reported-by: Andy Shevchenko > > > > on merge. But i would not want to send the whole series again for that > > one line. > > Since you added it, `b4` will happily take it, I believe no manual work even > needed for that, thank you! b4 didn't pick this up. Nor the whole-series Ack provided by Hans. I added both manually. -- Lee Jones [李琼斯]